linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Changing of WMM queue parameters forbidden for IBSS interfaces
@ 2017-02-01 14:24 Jörg Pommnitz
  2017-02-01 14:29 ` Jörg Pommnitz
  2017-02-08  6:58 ` Johannes Berg
  0 siblings, 2 replies; 3+ messages in thread
From: Jörg Pommnitz @ 2017-02-01 14:24 UTC (permalink / raw)
  To: linux-wireless

Hello all,

I'm trying to change the WMM parameters for an IBSS network. I'm
adding a command to set txq_params to iw. Sadly the current kernel
code explicitly denies this for interfaces other than AP and P2P (see
http://lxr.free-electrons.com/source/net/wireless/nl80211.c#L2279).

Is there a reason why this should not be done for IBSS interfaces?


Thanks in advance
  Joerg

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Changing of WMM queue parameters forbidden for IBSS interfaces
  2017-02-01 14:24 Changing of WMM queue parameters forbidden for IBSS interfaces Jörg Pommnitz
@ 2017-02-01 14:29 ` Jörg Pommnitz
  2017-02-08  6:58 ` Johannes Berg
  1 sibling, 0 replies; 3+ messages in thread
From: Jörg Pommnitz @ 2017-02-01 14:29 UTC (permalink / raw)
  To: linux-wireless

Sorry, wrong line in the link, the correct line is:
http://lxr.free-electrons.com/source/net/wireless/nl80211.c#L2289

regards
  Joerg

2017-02-01 15:24 GMT+01:00 J=C3=B6rg Pommnitz <j.pommnitz@gmail.com>:
> Hello all,
>
> I'm trying to change the WMM parameters for an IBSS network. I'm
> adding a command to set txq_params to iw. Sadly the current kernel
> code explicitly denies this for interfaces other than AP and P2P (see
> http://lxr.free-electrons.com/source/net/wireless/nl80211.c#L2279).
>
> Is there a reason why this should not be done for IBSS interfaces?
>
>
> Thanks in advance
>   Joerg

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Changing of WMM queue parameters forbidden for IBSS interfaces
  2017-02-01 14:24 Changing of WMM queue parameters forbidden for IBSS interfaces Jörg Pommnitz
  2017-02-01 14:29 ` Jörg Pommnitz
@ 2017-02-08  6:58 ` Johannes Berg
  1 sibling, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2017-02-08  6:58 UTC (permalink / raw)
  To: Jörg Pommnitz, linux-wireless

On Wed, 2017-02-01 at 15:24 +0100, Jörg Pommnitz wrote:
> Hello all,
> 
> I'm trying to change the WMM parameters for an IBSS network. I'm
> adding a command to set txq_params to iw. Sadly the current kernel
> code explicitly denies this for interfaces other than AP and P2P (see
> http://lxr.free-electrons.com/source/net/wireless/nl80211.c#L2279).
> 
> Is there a reason why this should not be done for IBSS interfaces?

I guess the whole thing was just ignored - we should also *adopt* the
EDCA parameters when joining an IBSS network, which I don't think we do
either.

I'm not sure we can actually modify them on the fly though - since
adoption is required, such changes would have a hard time propagating
through.

If really necessary, we'd have to implement adoption and probably only
allow setting it at IBSS creation time.

johannes

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-08  6:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-01 14:24 Changing of WMM queue parameters forbidden for IBSS interfaces Jörg Pommnitz
2017-02-01 14:29 ` Jörg Pommnitz
2017-02-08  6:58 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).