linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Adrian Chadd <adrian@freebsd.org>,
	"Valo, Kalle" <kvalo@qca.qualcomm.com>
Cc: "Ben Greear" <greearb@candelatech.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Amadeusz Sławiński" <amadeusz.slawinski@tieto.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()
Date: Thu, 09 Feb 2017 23:37:02 -0800	[thread overview]
Message-ID: <1486712222.2192.3.camel@perches.com> (raw)
In-Reply-To: <CAJ-Vmom7k3Tsgs8tRHQppmL7XxADS3V24AGOQY5QgkrSgr5Qzg@mail.gmail.com>

On Thu, 2017-02-09 at 23:14 -0800, Adrian Chadd wrote:

> If there
> were accessors for the skb data / len fields (like we do for mbufs)
> then porting the code would've involved about 5,000 less changed
> lines.

What generic mechanisms would you suggest to make
porting easier between bsd and linux and what in
your opinion are the best naming schemes to make
these functions easiest to read and implement
without resorting to excessive identifier lengths?

If you have some, please provide examples.

  reply	other threads:[~2017-02-10  7:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-02 10:19 [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Amadeusz Sławiński
2017-02-02 10:19 ` [PATCH 2/3] ath10k: use size_t for len variables Amadeusz Sławiński
2017-02-02 19:20   ` Sebastian Gottschall
2017-02-02 10:19 ` [PATCH 3/3] ath10k: fix comment Amadeusz Sławiński
2017-02-02 16:17 ` [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Adrian Chadd
2017-02-07  9:14   ` Valo, Kalle
2017-02-07 14:46     ` Ben Greear
2017-02-10  7:03       ` Valo, Kalle
2017-02-10  7:14         ` Adrian Chadd
2017-02-10  7:37           ` Joe Perches [this message]
2017-02-10 15:31             ` Adrian Chadd
2017-02-10 16:43         ` Ben Greear
2017-02-14 17:40 ` [1/3] " Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486712222.2192.3.camel@perches.com \
    --to=joe@perches.com \
    --cc=adrian@freebsd.org \
    --cc=amadeusz.slawinski@tieto.com \
    --cc=ath10k@lists.infradead.org \
    --cc=greearb@candelatech.com \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).