From: Johannes Berg <johannes@sipsolutions.net>
To: Ashok Raj Nagarajan <arnagara@qti.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
arnagara@codeaurora.org
Subject: Re: [PATCH v3] iw: Add support for controlling tx power for per station
Date: Wed, 15 Feb 2017 09:03:15 +0100 [thread overview]
Message-ID: <1487145795.4026.9.camel@sipsolutions.net> (raw)
In-Reply-To: <1486555277-25258-1-git-send-email-arnagara@qti.qualcomm.com> (sfid-20170208_131118_350049_87BE682C)
> + sta_txpwr = strtoul(argv[0], &err, 0);
you should error-check this.
> + NLA_PUT_U32(msg, NL80211_ATTR_STA_TX_POWER,
> sta_txpwr);
> + }
> +}
> +COMMAND_ALIAS(station, set, "<MAC address> txpwr <auto|limit> [<tx
> power mBm>]",
>
Seems like that should be
<MAC address> txpwr <auto|limit <tx power dBm>>
or so?
I made that dBm there, doing that and parsing floating point numbers
would be nice I think.
johannes
next prev parent reply other threads:[~2017-02-15 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 12:01 [PATCH v3] iw: Add support for controlling tx power for per station Ashok Raj Nagarajan
2017-02-15 8:03 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-22 6:37 Balaji Pothunoori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487145795.4026.9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arnagara@codeaurora.org \
--cc=arnagara@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).