From: Johannes Berg <johannes@sipsolutions.net>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, rmanohar@codeaurora.org
Subject: Re: [PATCH 1/2] mac80211: use DECLARE_EWMA for mesh_fail_avg
Date: Wed, 15 Feb 2017 09:13:59 +0100 [thread overview]
Message-ID: <1487146439.4026.10.camel@sipsolutions.net> (raw)
In-Reply-To: <1487104037-24941-1-git-send-email-rmanohar@qca.qualcomm.com>
On Tue, 2017-02-14 at 12:27 -0800, Rajkumar Manoharan wrote:
> As moving average is not considering fractional part, it
> will stuck at the same level after certain state. For example
> with current values, moving average stuck at 96 and it will
> not move forward. Fortunately current threshold is matching
> against 95%. If thresold is increased more than 96, mesh path
> never be deactivated under worst case. Fix failure average
> movement by using EWMA helpers.
Thanks, applied.
> +DECLARE_EWMA(mesh_fail_avg, 64, 8)
Since we only feed in small values (0-100), I picked a much larger
factor (1<<20) to give more precision here.
johannes
prev parent reply other threads:[~2017-02-15 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 20:27 [PATCH 1/2] mac80211: use DECLARE_EWMA for mesh_fail_avg Rajkumar Manoharan
2017-02-14 20:27 ` [PATCH 2/2] mac80211: fix mesh fail_avg check Rajkumar Manoharan
2017-02-15 8:14 ` Johannes Berg
2017-02-15 8:13 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487146439.4026.10.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@codeaurora.org \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).