From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: linux-wireless@vger.kernel.org, Eliad Peller <eliad@wizery.com>
Subject: Re: [RFC v2 1/2] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK
Date: Tue, 21 Feb 2017 15:47:27 +0100 [thread overview]
Message-ID: <1487688447.15350.4.camel@sipsolutions.net> (raw)
In-Reply-To: <1487688369.15350.3.camel@sipsolutions.net> (sfid-20170221_154616_216812_DC7B7832)
> The .len verifies that it's at least that long. We're thus ignoring
> additional bytes in the PSK case if they're present, which I suppose
> we should fix by checking the exact length in the code separately.
>
IOW, I'll add this:
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -8044,6 +8044,8 @@ static int nl80211_crypto_settings(struct cfg80211_registered_device *rdev,
if (!wiphy_ext_feature_isset(&rdev->wiphy,
NL80211_EXT_FEATURE_4WAY_HANDSHAKE_STA_PSK))
return -EINVAL;
+ if (nla_len(info->attrs[NL80211_ATTR_PMK]) != WLAN_PMK_LEN)
+ return -EINVAL;
settings->psk = nla_data(info->attrs[NL80211_ATTR_PMK]);
}
johannes
next prev parent reply other threads:[~2017-02-21 14:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 12:37 [RFC v2 1/2] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK Johannes Berg
2017-02-21 12:37 ` [RFC v2 2/2] cfg80211: support 4-way handshake offloading for 802.1X Johannes Berg
2017-02-24 8:08 ` Arend Van Spriel
2017-03-02 8:59 ` Johannes Berg
2017-03-02 10:50 ` Arend Van Spriel
2017-03-28 10:50 ` Arend Van Spriel
2017-03-31 11:50 ` Johannes Berg
2017-03-31 12:39 ` Arend Van Spriel
2017-03-31 12:42 ` Johannes Berg
2017-03-31 18:40 ` Arend Van Spriel
2017-02-21 14:43 ` [RFC v2 1/2] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK Jouni Malinen
2017-02-21 14:46 ` Johannes Berg
2017-02-21 14:47 ` Johannes Berg [this message]
2017-02-23 9:56 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487688447.15350.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=eliad@wizery.com \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).