From: Joe Perches <joe@perches.com>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>,
Tahia Khan <tahia.khan@gmail.com>,
outreachy-kernel@googlegroups.com, aditya.shankar@microchip.com,
ganesh.krishna@microchip.com, gregkh@linuxfoundation.org,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full
Date: Wed, 22 Feb 2017 22:24:26 -0800 [thread overview]
Message-ID: <1487831066.14159.17.camel@perches.com> (raw)
In-Reply-To: <838d3e67-646d-b2d3-ef7d-5812675db6db@broadcom.com>
On Wed, 2017-02-22 at 20:50 +0100, Arend Van Spriel wrote:
> On 22-2-2017 18:14, Tahia Khan wrote:
> > Fixes multiple camel case checks on struct tstrRSSI from checkpatch.pl:
[]
> Just a generic remark that may help you with other changes you will be
> making in the linux kernel. Warnings from checkpatch.pl and other tools
> are useful, but try to look further than just fixing a warning.
> Understand what the code is doing is just as important.
I'd assert understanding what the code is doing is
_more_ important. Style consistency simply helps
improve the speed of a new reader's understanding.
prev parent reply other threads:[~2017-02-23 6:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 17:14 [PATCH v2] staging: wilc1000: renames struct tstrRSSI and its members u8Index, u8Full Tahia Khan
2017-02-22 19:50 ` Arend Van Spriel
2017-02-23 3:54 ` Tahia Khan
2017-02-23 7:08 ` [Outreachy kernel] " Julia Lawall
2017-02-23 8:56 ` Arend Van Spriel
2017-02-23 13:38 ` Julia Lawall
2017-02-23 6:24 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487831066.14159.17.camel@perches.com \
--to=joe@perches.com \
--cc=aditya.shankar@microchip.com \
--cc=arend.vanspriel@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=tahia.khan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).