From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 099/306] mac80211-hwsim: notify user-space about channel change.
Date: Fri, 24 Feb 2017 07:36:37 +0100 [thread overview]
Message-ID: <1487918197.2540.1.camel@sipsolutions.net> (raw)
In-Reply-To: <1487896109-23851-1-git-send-email-greearb@candelatech.com> (sfid-20170224_012921_813683_C1D64839)
> + msg_head = genlmsg_put(skb, 0, 0, &hwsim_genl_family, 0,
> + HWSIM_CMD_NOTIFY);
I think you should use a more specific command name.
> + if (nla_put(skb, HWSIM_ATTR_ADDR_TRANSMITTER,
> + ETH_ALEN, data->addresses[1].addr))
> + goto nla_put_failure;
and at least also add a more specific identifier like the radio ID.
> + if (data->channel)
> + center_freq = data->channel->center_freq;
> +
> + if (nla_put_u32(skb, HWSIM_ATTR_FREQ, center_freq))
> + goto nla_put_failure;
and have the full channel definition
Also the indentation in the documentation didn't match the convention
used there.
johannes
next prev parent reply other threads:[~2017-02-24 6:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 0:28 [PATCH 099/306] mac80211-hwsim: notify user-space about channel change greearb
2017-02-24 0:28 ` [PATCH 100/306] mac80211-hwsim: remove dmesg spam about get-survey greearb
2017-02-24 6:36 ` Johannes Berg
2017-02-24 0:28 ` [PATCH 101/306] mac80211-hwsim: Pass rate-ctrl flags and tx-power to user-space greearb
2017-02-24 6:37 ` Johannes Berg
2017-02-24 0:28 ` [PATCH 102/306] mac80211-hwsim: enable better rx-status when using netlink greearb
2017-02-24 6:38 ` Johannes Berg
2017-02-24 0:28 ` [PATCH 160/306] mac80211-hwsim: add rate-limited debugging for rx-netlink greearb
2017-02-24 6:39 ` Johannes Berg
2017-02-24 15:27 ` Ben Greear
2017-02-27 14:33 ` Johannes Berg
2017-02-24 0:28 ` [PATCH 161/306] mac80211-hwsim: Improve logging greearb
2017-02-24 6:42 ` Johannes Berg
2017-02-24 15:26 ` Ben Greear
2017-02-24 0:28 ` [PATCH 162/306] mac80211-hwsim: add length checks before allocating skb greearb
2017-02-24 6:43 ` Johannes Berg
2017-02-24 8:45 ` Andrew Zaborowski
2017-02-24 15:19 ` Ben Greear
2017-02-24 6:36 ` Johannes Berg [this message]
2017-02-24 15:39 ` [PATCH 099/306] mac80211-hwsim: notify user-space about channel change Ben Greear
2017-02-27 14:34 ` Johannes Berg
2017-02-27 20:48 ` Ben Greear
2017-03-02 8:38 ` Johannes Berg
2017-03-02 14:26 ` Ben Greear
2017-02-27 21:00 ` Ben Greear
2017-03-02 8:39 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487918197.2540.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).