From: Johannes Berg <johannes@sipsolutions.net>
To: Andrew Zaborowski <andrew.zaborowski@intel.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2][RFC] mac80211_hwsim: Report radio addresses in NEW_RADIO/GET_RADIO
Date: Mon, 27 Feb 2017 14:27:42 +0100 [thread overview]
Message-ID: <1488202062.28431.7.camel@sipsolutions.net> (raw)
In-Reply-To: <20170223120211.22358-2-andrew.zaborowski@intel.com> (sfid-20170223_133157_932062_C356BD66)
> Additionally I tried to add a HWSIM_ATTR_WIPHY to report the wiphy
> index directly without users going through wiphy name to index
> mapping, but get_wiphy_idx() is internal to cfg80211. The index is
> exposed to userspace and is more useful than the name so I wonder if
> this function should be exported from cfg80211.
Do you really need the address?
I'd actually prefer to *only* have the wiphy index, and I don't really
see a problem with moving the wiphy_idx from struct
cfg80211_registered_device to struct wiphy.
johannes
next prev parent reply other threads:[~2017-02-27 13:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 12:02 [PATCH 1/2] mac80211_hwsim: Make sure NEW_RADIO contains final name Andrew Zaborowski
2017-02-23 12:02 ` [PATCH 2/2][RFC] mac80211_hwsim: Report radio addresses in NEW_RADIO/GET_RADIO Andrew Zaborowski
2017-02-23 19:01 ` Benjamin Beichler
2017-02-24 0:02 ` Andrew Zaborowski
2017-02-24 0:25 ` Ben Greear
2017-02-27 13:27 ` Johannes Berg [this message]
2017-02-27 15:26 ` Andrew Zaborowski
2017-02-27 17:10 ` Ben Greear
2017-02-28 1:23 ` Andrew Zaborowski
2017-02-28 1:57 ` Ben Greear
2017-03-01 14:33 ` Benjamin Beichler
2017-03-01 15:35 ` Ben Greear
2017-03-01 17:04 ` Benjamin Beichler
2017-03-02 8:23 ` Johannes Berg
2017-02-24 0:08 ` [PATCH 1/2] mac80211_hwsim: Make sure NEW_RADIO contains final name Andrew Zaborowski
2017-02-27 13:24 ` Johannes Berg
2017-02-27 15:16 ` Andrew Zaborowski
2017-02-27 16:08 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488202062.28431.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andrew.zaborowski@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).