linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: agreen@cococorp.com, linux-wireless@vger.kernel.org
Cc: Jesse Jones <jjones@cococorp.com>
Subject: Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.
Date: Mon, 27 Feb 2017 14:30:27 +0100	[thread overview]
Message-ID: <1488202227.28431.9.camel@sipsolutions.net> (raw)
In-Reply-To: <58B09082.7020704@cococorp.com> (sfid-20170224_205905_277542_E6C0402D)

On Fri, 2017-02-24 at 11:58 -0800, Alexis Green wrote:
> From: Jesse Jones <jjones@uniumwifi.com>
> 
> Changes since v1: Only flush tx queue if interface is mesh mode.
>   This prevents kernel panics due to uninitialized spin_lock.
> 
> When more than one station hears a broadcast request, it is possible
> that multiple devices will reply at the same time, potentially
> causing collision. This patch helps reduce this issue.

It's not clear to me what you mean by "collision"? Over the air the NAV
should handle the avoidance thereof, so I don't really see what this
does wrt. collisions?

Are these frames somehow duplicates? But I don't see any suppression if
you've already put a frame on the "jittered" list then it will never be
deleted from it again, so it doesn't suppress anything in that sense?

johannes

  reply	other threads:[~2017-02-27 13:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-24 19:58 [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks Alexis Green
2017-02-27 13:30 ` Johannes Berg [this message]
2017-02-27 20:10   ` Alexis Green
2017-03-02  8:36     ` Johannes Berg
2017-03-02 17:41       ` Jesse Jones
2017-03-06 12:38         ` Johannes Berg
2017-03-06 18:01           ` Jesse Jones
2017-03-09 15:49           ` Matthias May
2017-03-10  8:40             ` Kalle Valo
2017-03-10 15:24               ` Alexis Green
2017-03-13 15:49             ` Benjamin Beichler
2017-03-14 13:45             ` Johannes Berg
2017-03-20 16:41         ` Thomas Pedersen
2017-03-16 10:16 ` Johannes Berg
2017-03-16 10:18 ` Johannes Berg
2017-03-19  1:48   ` Alexis Green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488202227.28431.9.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=agreen@cococorp.com \
    --cc=jjones@cococorp.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).