linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Benjamin Beichler <Benjamin.Beichler@uni-rostock.de>,
	Ben Greear <greearb@candelatech.com>,
	Andrew Zaborowski <andrew.zaborowski@intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2][RFC] mac80211_hwsim: Report radio addresses in NEW_RADIO/GET_RADIO
Date: Thu, 02 Mar 2017 09:23:11 +0100	[thread overview]
Message-ID: <1488442991.8390.1.camel@sipsolutions.net> (raw)
In-Reply-To: <60000eb2-f404-aab7-5493-9b952adb1dde@uni-rostock.de>

On Wed, 2017-03-01 at 18:04 +0100, Benjamin Beichler wrote:
> Am 01.03.2017 um 16:35 schrieb Ben Greear:
> > That is actually not possible. The permanent MAC-Addresses of hwsim
> > 
> > > radios are directly created by there internal ID, which is only
> > > increased for new radios and definitely not reassigned.
> > > 
> > > But I would be happy, if this were possible, since it would make
> > > some
> > > simulation related stuff easier (currently we need to unload and
> > > load
> > > the hwsim module over and over again for every run).
> > 
> > Ahh, you are right.  But you can specify the wiphy name, and then
> > you
> > can use that to query the debugfs to find the MAC addr, and then
> > sync
> > your user-space with that info.
> > 
> > It should also be easy enough to specify the MAC address when
> > creating
> > the radio.
> > 
> > And, you should be able to create virtual STA, AP, etc, with any
> > specified
> > MAC address, so the MAC of the radio really should not matter much?
> > 
> 
> That is another problem ... this won't work currently, since the
> frame
> delivery compares the receiver address with the permanent MAC
> addresses
> of all hwsim phys. I work as an idle task on patch, which makes this
> lookup (currently implemented as linear search) as a hashmap mapping
> an
> MAC to a wiphy struct , including scenarios with differing MAC
> addresses
> of vifs.

That's probably something we really ought to fix :)

johannes

  reply	other threads:[~2017-03-02  9:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23 12:02 [PATCH 1/2] mac80211_hwsim: Make sure NEW_RADIO contains final name Andrew Zaborowski
2017-02-23 12:02 ` [PATCH 2/2][RFC] mac80211_hwsim: Report radio addresses in NEW_RADIO/GET_RADIO Andrew Zaborowski
2017-02-23 19:01   ` Benjamin Beichler
2017-02-24  0:02     ` Andrew Zaborowski
2017-02-24  0:25       ` Ben Greear
2017-02-27 13:27   ` Johannes Berg
2017-02-27 15:26     ` Andrew Zaborowski
2017-02-27 17:10       ` Ben Greear
2017-02-28  1:23         ` Andrew Zaborowski
2017-02-28  1:57           ` Ben Greear
2017-03-01 14:33             ` Benjamin Beichler
2017-03-01 15:35               ` Ben Greear
2017-03-01 17:04                 ` Benjamin Beichler
2017-03-02  8:23                   ` Johannes Berg [this message]
2017-02-24  0:08 ` [PATCH 1/2] mac80211_hwsim: Make sure NEW_RADIO contains final name Andrew Zaborowski
2017-02-27 13:24   ` Johannes Berg
2017-02-27 15:16     ` Andrew Zaborowski
2017-02-27 16:08       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488442991.8390.1.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Benjamin.Beichler@uni-rostock.de \
    --cc=andrew.zaborowski@intel.com \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).