From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga09.intel.com ([134.134.136.24]:61177 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755406AbdCGM64 (ORCPT ); Tue, 7 Mar 2017 07:58:56 -0500 Message-ID: <1488881748.20145.102.camel@linux.intel.com> (sfid-20170307_140031_943277_89B38D5E) Subject: Re: [PATCH v1 1/2] NFC: pn544: Request GPIOs with proper connection IDs From: Andy Shevchenko To: Lauro Ramos Venancio , Aloisio Almeida Jr , Samuel Ortiz , linux-wireless@vger.kernel.org, Mika Westerberg Date: Tue, 07 Mar 2017 12:15:48 +0200 In-Reply-To: <20170307101230.23062-1-andriy.shevchenko@linux.intel.com> References: <20170307101230.23062-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2017-03-07 at 12:12 +0200, Andy Shevchenko wrote: > Since ACPI does support _DSD we might have a firmware that provides a > GPIO mapping in DSDT. When GPIO is requested the core will check for > property with given name. That's why we have to follow the standard > names which are already in use in DT case. > > Request GPIOs with proper connection IDs, i.e. use same names as used > for DT case. > > In the future ACPI and DT cases might be unified. Discard this series, it should be v2, just resent. > > Signed-off-by: Andy Shevchenko > --- >  drivers/nfc/pn544/i2c.c | 6 ++---- >  1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/nfc/pn544/i2c.c b/drivers/nfc/pn544/i2c.c > index f837c39a8017..2df3176205c4 100644 > --- a/drivers/nfc/pn544/i2c.c > +++ b/drivers/nfc/pn544/i2c.c > @@ -881,8 +881,7 @@ static int > pn544_hci_i2c_acpi_request_resources(struct i2c_client *client) >   struct device *dev = &client->dev; >   >   /* Get EN GPIO from ACPI */ > - gpiod_en = devm_gpiod_get_index(dev, PN544_GPIO_NAME_EN, 1, > - GPIOD_OUT_LOW); > + gpiod_en = devm_gpiod_get_index(dev, "enable", 1, > GPIOD_OUT_LOW); >   if (IS_ERR(gpiod_en)) { >   nfc_err(dev, "Unable to get EN GPIO\n"); >   return -ENODEV; > @@ -891,8 +890,7 @@ static int > pn544_hci_i2c_acpi_request_resources(struct i2c_client *client) >   phy->gpio_en = desc_to_gpio(gpiod_en); >   >   /* Get FW GPIO from ACPI */ > - gpiod_fw = devm_gpiod_get_index(dev, PN544_GPIO_NAME_FW, 2, > - GPIOD_OUT_LOW); > + gpiod_fw = devm_gpiod_get_index(dev, "firmware", 2, > GPIOD_OUT_LOW); >   if (IS_ERR(gpiod_fw)) { >   nfc_err(dev, "Unable to get FW GPIO\n"); >   return -ENODEV; -- Andy Shevchenko Intel Finland Oy