Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Rostyslav Khudolii <rkhudolii@airtame.com>
Cc: kvalo@qca.qualcomm.com, ath6kl@lists.infradead.org,
	linux-wireless@vger.kernel.org,
	Attila Sukosd <attila@airtame.com>
Subject: Re: [PATCH] ath6kl: Remove old 802.11a-only channels
Date: Fri, 10 Mar 2017 10:15:11 +0100	[thread overview]
Message-ID: <1489137311.3038.3.camel@sipsolutions.net> (raw)
In-Reply-To: <CAPXt_daQxHAsPfeRjP0CZfq_Uu4EXHvjsko-EUb0mKmDaef_SQ@mail.gmail.com> (sfid-20170310_101153_737719_AB380131)

On Fri, 2017-03-10 at 10:11 +0100, Rostyslav Khudolii wrote:
> On 10 March 2017 at 09:56, Johannes Berg <johannes@sipsolutions.net>
> wrote:
> > On Fri, 2017-03-10 at 09:49 +0100, Rostyslav Khudolii wrote:
> > > Channels 34/38/42/46 can only be used for compatibility with
> > > old devices sold in Japan. Modern products, such as AR6003/AR6004
> > > don't support these channels.
> > > Keeping them in the upstream is error prone and requires full
> > > network stack support.
> > 
> > Seems pointless. Nothing in the network stack really cares much
> > about
> > the channel numbers, so what exactly does this improve?
> > 
> 
> Without this one, a user is able to start an AP using wpa_supplicant,
> for example, on one of these channels (34/38/42/46), without getting
> any warning/error from the cfg80211 or ath6kl - which is correct
> (since these channels match regdom rules). However, the AR6003 and
> its
> firmware (we're using v3.4.0.225) will fail and return
> "WMI_CMDERROR_EVENTID" with "INVALID_PARAM" error code.
> In my opinion, ath6kl shouldn't support anything the firmware
> doesn't.
> We should also handle WMI_CMDERROR_EVENTID properly (not just
> printing
> a message), but this is another problem, I believe.

Ah. I didn't make the connection that AR6003 was actually a product
that used this driver and thought you were using it as another peer and
then the two couldn't make a connection...

My bad.

johannes

  reply	other threads:[~2017-03-10  9:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10  8:49 [PATCH] ath6kl: Remove old 802.11a-only channels Rostyslav Khudolii
2017-03-10  8:56 ` Johannes Berg
2017-03-10  9:11   ` Rostyslav Khudolii
2017-03-10  9:15     ` Johannes Berg [this message]
2017-03-10 10:42       ` Valo, Kalle
2017-03-16  9:36 ` Kalle Valo
2017-03-16  9:46   ` Rostyslav Khudolii
2017-03-20 15:28 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489137311.3038.3.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath6kl@lists.infradead.org \
    --cc=attila@airtame.com \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rkhudolii@airtame.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox