Re: brcmfmac and WIPHY_FLAG_NETNS_OK

[Johannes Berg <johannes@sipsolutions.net>]

> It never came up with any projects so far. I doubt that the patch
> below is sufficient. I suspect something more is needed. Using git
> blame I ended up finding these commits:
> 
> a272a72 mac80211: allow using network namespaces

This is needed in brcm drivers.

> 463d018 cfg80211: make aware of net namespaces

This has no impact on brcm drivers :)

> 5061b0c mac80211: cooperate more with network namespaces

This shouldn't be needed, you're not referring to init_net in brcm
drivers.

> I think what is required from brcmfmac is to set netns for each
> netdev that we create to the same netns as the wiphy instance using
> wiphy_net().

Yes, like the mac80211 patch above.

> Not sure if there is more to consider, but hopefully Johannes can
> comment on this although the mentioned commits have been around for a
> while.

I don't think there's anything else.

> >         wiphy->flags |= WIPHY_FLAG_PS_ON_BY_DEFAULT |
> >                         WIPHY_FLAG_OFFCHAN_TX |
> > -                       WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL;
> > +                       WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL |
> > +                       WIPHY_FLAG_NETNS_OK;

This is not sufficient, you still have to set the netns for newly
created netdevs.

johannes