From: Johannes Berg <johannes@sipsolutions.net>
To: Sven Eckelmann <sven.eckelmann@openmesh.com>,
linux-wireless@vger.kernel.org
Cc: simon.wunderlich@openmesh.com, Benjamin Berg <benjamin@sipsolutions.net>
Subject: Re: [PATCH] mac80211: Allow multiple listeners for management frames.
Date: Tue, 14 Mar 2017 14:51:01 +0100 [thread overview]
Message-ID: <1489499461.10872.4.camel@sipsolutions.net> (raw)
In-Reply-To: <20170310093454.27664-1-sven.eckelmann@openmesh.com> (sfid-20170310_103523_108597_73CF7884)
On Fri, 2017-03-10 at 10:34 +0100, Sven Eckelmann wrote:
> From: Benjamin Berg <benjamin@sipsolutions.net>
>
> Previously it was not possible to have multiple listeners for
> management frames in userspace. This is a bit weird as multiple
> processes in userspace might try to request management frame
> reporting but only the first request was accepted.
I vaguely remember discussing this with Benjamin.
> It is currently unknown why Benjamin never forwarded it. I am doing
> this now to have a chance that this private patch doesn't have to be
> rebased anymore by OpenMesh.
I'm not sure I mentioned it to him, or even remembered it when we were
discussing it, but I don't think this patch is a good idea, at least
for action frames.
For non-action frames, I don't see any problem.
However, for action frames, if you subscribe you get the responsibility
to return if unhandled (setting 0x80 in the action code fields).
With multiple subscribers, that becomes impossible.
If you restrict it to non-action I can live with it, but I don't know
what you really want to do with this.
johannes
next prev parent reply other threads:[~2017-03-14 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 9:34 [PATCH] mac80211: Allow multiple listeners for management frames Sven Eckelmann
2017-03-14 13:51 ` Johannes Berg [this message]
2017-03-14 14:06 ` Sven Eckelmann
2017-03-14 14:10 ` Simon Wunderlich
2017-03-14 14:13 ` Johannes Berg
2017-03-14 14:21 ` Sven Eckelmann
2017-03-14 14:27 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489499461.10872.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=benjamin@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=simon.wunderlich@openmesh.com \
--cc=sven.eckelmann@openmesh.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).