From: Johannes Berg <johannes@sipsolutions.net>
To: Masashi Honma <masashi.honma@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: Drop new node with weak power
Date: Fri, 17 Mar 2017 13:28:12 +0100 [thread overview]
Message-ID: <1489753692.2544.9.camel@sipsolutions.net> (raw)
In-Reply-To: <d0eb6984-6ae7-d984-b61a-0c98603294ae@gmail.com> (sfid-20170317_065642_176557_2AC4F6FC)
On Fri, 2017-03-17 at 14:56 +0900, Masashi Honma wrote:
> > It seems that this is really what the meshcfg.rssi_threshold was
> > intended for, and the plink code *does* take it into account. Can
> > you
> > explain where that's breaking down?
>
> Indeed meshcfg.rssi_threshold is already referred by some codes. But
> when booting mesh node with user_mpm=1, the codes is not called.
> So we need to add another code.
Hmm. If path selection isn't done by mac80211 in this case, wouldn't it
be more appropriate to put this logic into the (userspace) component
that does path selection?
IOW, I'm not convinced that outright not adding the *peer* is a good
idea either way - it seems much better to me to not use the *path*.
johannes
next prev parent reply other threads:[~2017-03-17 12:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 1:57 [PATCH 1/2] nl80211: Use signed function for a signed variable Masashi Honma
2017-03-16 1:57 ` [PATCH 2/2] mac80211: Drop new node with weak power Masashi Honma
2017-03-16 10:03 ` Johannes Berg
2017-03-17 5:56 ` Masashi Honma
2017-03-17 12:28 ` Johannes Berg [this message]
2017-03-20 6:39 ` Masashi Honma
2017-03-29 8:26 ` Johannes Berg
2017-03-16 9:55 ` [PATCH 1/2] nl80211: Use signed function for a signed variable Johannes Berg
2017-03-17 5:59 ` [PATCH v2] mac80211: Use rssi_threshold even though user_mpm=1 Masashi Honma
2017-03-26 20:53 ` Masashi Honma
2017-03-29 8:29 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489753692.2544.9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=masashi.honma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).