From: Johannes Berg <johannes@sipsolutions.net>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>,
linux-wireless@vger.kernel.org
Cc: Avraham Stern <avraham.stern@intel.com>
Subject: Re: [RFC v2 2/2] cfg80211: support 4-way handshake offloading for 802.1X
Date: Fri, 31 Mar 2017 13:50:01 +0200 [thread overview]
Message-ID: <1490961001.6288.8.camel@sipsolutions.net> (raw)
In-Reply-To: <5274c4b4-9bce-208c-e3f2-640d54b81a30@broadcom.com> (sfid-20170328_125041_391430_D9B7273C)
On Tue, 2017-03-28 at 12:50 +0200, Arend Van Spriel wrote:
>
> So looking at wpa_supplicant RFC patches I see that it now diverts
> driver_nl80211_set_key() for ALG_PMK case to the new api. So why not
> extending CMD_NEW_KEY to support ALG_PMK?
I don't really care what the supplicant does, but IMHO having
completely different types of keys in the same API isn't a good idea.
We'd have to invent (a) cipher suite(s), or new attributes, to even
encapsulate that in netlink - and the usage is completely different
etc.
johannes
next prev parent reply other threads:[~2017-03-31 11:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 12:37 [RFC v2 1/2] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK Johannes Berg
2017-02-21 12:37 ` [RFC v2 2/2] cfg80211: support 4-way handshake offloading for 802.1X Johannes Berg
2017-02-24 8:08 ` Arend Van Spriel
2017-03-02 8:59 ` Johannes Berg
2017-03-02 10:50 ` Arend Van Spriel
2017-03-28 10:50 ` Arend Van Spriel
2017-03-31 11:50 ` Johannes Berg [this message]
2017-03-31 12:39 ` Arend Van Spriel
2017-03-31 12:42 ` Johannes Berg
2017-03-31 18:40 ` Arend Van Spriel
2017-02-21 14:43 ` [RFC v2 1/2] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK Jouni Malinen
2017-02-21 14:46 ` Johannes Berg
2017-02-21 14:47 ` Johannes Berg
2017-02-23 9:56 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490961001.6288.8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=avraham.stern@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).