From: Johannes Berg <johannes@sipsolutions.net>
To: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, Jouni Malinen <j@w1.fi>
Subject: Re: [PATCH V2 3/3] cfg80211: Share Channel DFS state across wiphys of same DFS domain
Date: Tue, 18 Apr 2017 12:50:04 +0200 [thread overview]
Message-ID: <1492512604.2472.20.camel@sipsolutions.net> (raw)
In-Reply-To: <1488195275-29371-4-git-send-email-vthiagar@qti.qualcomm.com>
> +void regulatory_propagate_dfs_state(struct wiphy *wiphy,
> + struct cfg80211_chan_def
> *chandef,
> + enum nl80211_dfs_state
> dfs_state,
> + enum nl80211_radar_event event)
> +{
> + struct cfg80211_registered_device *rdev;
> +
> + ASSERT_RTNL();
> +
> + if (WARN_ON(!cfg80211_chandef_valid(chandef)))
> + return;
> +
> + if (WARN_ON(!(chandef->chan->flags & IEEE80211_CHAN_RADAR)))
> + return;
This warn on reliably triggers for me when I run the "ap_vht160" hwsim
test from wpa_supplicant.
I think there might be some confusion about this when parts of the 160
MHz channel require radar and parts don't? But I haven't looked into
this at all.
Please send me a fix ASAP so Jouni doesn't shout at me for test
failures :)
johannes
next prev parent reply other threads:[~2017-04-18 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 11:34 [PATCH V2 0/3] Pre-CAC and sharing DFS state across multiple radios Vasanthakumar Thiagarajan
2017-02-27 11:34 ` [PATCH V2 1/3] cfg80211: Make pre-CAC results valid only for ETSI domain Vasanthakumar Thiagarajan
2017-02-27 11:34 ` [PATCH V2 2/3] cfg80211: Disallow moving out of operating DFS channel in non-ETSI Vasanthakumar Thiagarajan
2017-02-27 11:34 ` [PATCH V2 3/3] cfg80211: Share Channel DFS state across wiphys of same DFS domain Vasanthakumar Thiagarajan
2017-04-18 10:50 ` Johannes Berg [this message]
2017-04-18 12:08 ` Vasanthakumar Thiagarajan
2017-03-06 12:54 ` [PATCH V2 0/3] Pre-CAC and sharing DFS state across multiple radios Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492512604.2472.20.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).