From: Bastien Nocera <hadess@hadess.net>
To: Ian W MORRISON <ianwmorrison@gmail.com>, linux-wireless@vger.kernel.org
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
jes.sorensen@gmail.com, Hans de Goede <hdegoede@redhat.com>,
gregkh@linuxfoundation.org
Subject: Re: [PATCH] staging: rtl8723bs: Revert ignoring_unreachable_code kfree
Date: Thu, 27 Apr 2017 15:47:07 +0200 [thread overview]
Message-ID: <1493300827.2281.13.camel@hadess.net> (raw)
In-Reply-To: <CAFXWsS9rNZ1QWt_CNK-gOfb1Mqwch25XxB43d6B_8SX76vBW4Q@mail.gmail.com>
On Thu, 2017-04-27 at 23:44 +1000, Ian W MORRISON wrote:
> I tried building the RTL8723BS SDIO wifi driver which has just been
> incorporated in staging for linux-next as an external module and
> found that it fails with 'Segmentation Fault'. I've tracked this down
> to commit 6557ddfec348c13d7798ea9e44f11b6459f2f652 (staging:
> rtl8723bs: Fix various errors in os_dep/ioctl_cfg80211.c) which
> includes the fix
> 'drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:3547
> rtw_wdev_alloc() info: ignoring unreachable code'. The moving of line
> 'kfree((u8 *)wdev);' causes the segmentation error so I've included
> the following patch to revert it.
What error? Both versions look equally incorrect, eg. either it's
leaking data in which case the kfree() is necessary and should be in a
callable location, or it's not, and the call should be removed.
next parent reply other threads:[~2017-04-27 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAFXWsS9fNn=YF--408O=weoNHfAv+g+CXJ8Df8=BC4m4Lt1aSg@mail.gmail.com>
[not found] ` <CAFXWsS9rNZ1QWt_CNK-gOfb1Mqwch25XxB43d6B_8SX76vBW4Q@mail.gmail.com>
2017-04-27 13:47 ` Bastien Nocera [this message]
[not found] ` <CAFXWsS98BbApyuYzFNhhXKzSRv=oE4GfoTFO1wBbjyKBidW92A@mail.gmail.com>
2017-04-27 14:05 ` [PATCH] staging: rtl8723bs: Revert ignoring_unreachable_code kfree Bastien Nocera
[not found] ` <CAFXWsS_jYO+ttoS0QyAmLzDEMDrwbXhgznm-AGMKGGED3fgGZg@mail.gmail.com>
2017-04-27 15:21 ` Fwd: " Ian W MORRISON
2017-04-27 15:58 ` Larry Finger
2017-04-27 16:35 ` Ian W MORRISON
2017-04-27 17:46 ` Larry Finger
2017-04-27 14:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493300827.2281.13.camel@hadess.net \
--to=hadess@hadess.net \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=ianwmorrison@gmail.com \
--cc=jes.sorensen@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).