From: "Mohammed Shafi Shajakhan (Mohammed Shafi)" <mohammed@qti.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "mohammed@codeaurora.org" <mohammed@codeaurora.org>,
"michal.kazior@tieto.com" <michal.kazior@tieto.com>
Subject: Re: [PATCH] mac80211: Fix possible sband related NULL pointer de-reference
Date: Fri, 28 Apr 2017 10:38:10 +0000 [thread overview]
Message-ID: <1493375889856.46906@qti.qualcomm.com> (raw)
In-Reply-To: <1493371140.2431.6.camel@sipsolutions.net>
On Thu, 2017-04-27 at 12:45 +0530, Mohammed Shafi Shajakhan wrote:=0A=
> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>=0A=
>=0A=
> Existing API 'ieee80211_get_sdata_band' returns default 2 GHz band=0A=
> even=0A=
> if the channel context configuration is NULL. This crashes for=0A=
> chipsets=0A=
> which support 5 Ghz alone when it tries to access members of 'sband'.=0A=
> Channel context configuration can be NULL in multivif case and when=0A=
> channel switch is in progress (or) when it fails. Fix this by=0A=
> replacing=0A=
> the API 'ieee80211_get_sdata_band' with 'ieee80211_get_sband' which=0A=
> returns a NULL pointer for sband when the channel configuration is=0A=
> NULL.=0A=
=0A=
Makes sense.=0A=
=0A=
Applied, but could you point to the one that actually crashed?=0A=
=0A=
[shafi] thanks johannes, it crashed @=0A=
=0A=
405 smps =3D (sband->ht_cap.cap & IEEE80211_HT_CAP_SM_PS) =
>>=0A=
406 IEEE80211_HT_CAP_SM_PS_SHIFT;=0A=
prev parent reply other threads:[~2017-04-28 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 7:15 [PATCH] mac80211: Fix possible sband related NULL pointer de-reference Mohammed Shafi Shajakhan
2017-04-28 9:19 ` Johannes Berg
2017-04-28 10:38 ` Mohammed Shafi Shajakhan (Mohammed Shafi) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493375889856.46906@qti.qualcomm.com \
--to=mohammed@qti.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
--cc=mohammed@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).