From: Joe Perches <joe@perches.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>,
Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
Dmitrii Lebed <dlebed@quantenna.com>,
Sergei Maksimenko <smaksimenko@quantenna.com>,
Sergey Matyukevich <smatyukevich@quantenna.com>,
Bindu Therthala <btherthala@quantenna.com>,
"hwang@quantenna.com" <hwang@quantenna.com>,
Kamlesh Rath <krath@quantenna.com>,
Avinash Patil <avinashp@quantenna.com>
Subject: Re: [v6] qtnfmac: introduce new FullMAC driver for Quantenna chipsets
Date: Fri, 12 May 2017 08:43:03 -0700 [thread overview]
Message-ID: <1494603783.2028.21.camel@perches.com> (raw)
In-Reply-To: <87shkap0e5.fsf@kamboji.qca.qualcomm.com>
On Fri, 2017-05-12 at 15:20 +0000, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
> Here's the diff between v5 and v6:
trivia:
> diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
[]
> @@ -93,9 +94,11 @@ qtnf_change_virtual_intf(struct wiphy *wiphy,
>
> qtnf_scan_done(vif->mac, true);
>
> - if (qtnf_cmd_send_change_intf_type(vif, type, mac_addr)) {
> - pr_err("failed to change interface type\n");
> - return -EFAULT;
> + ret = qtnf_cmd_send_change_intf_type(vif, type, mac_addr);
> + if (ret) {
> + pr_err("VIF%u.%u: failed to change VIF type: %d\n",
> + vif->mac->macid, vif->vifid, ret);
It might make sense to add vif_<level> macros or functions
to make sure the vif->mac->macid, vif->vifid are emitted
consistently and simplify the calls
For instance:
vif_err(vif, "failed to change VIF type %d\n", ret);
etc...
Not necessarily in this patch, maybe in a future one.
next prev parent reply other threads:[~2017-05-12 15:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 21:51 [PATCH v6] qtnfmac: introduce new FullMAC driver for Quantenna chipsets igor.mitsyanko.os
2017-05-12 15:18 ` [v6] " Kalle Valo
2017-05-12 15:20 ` Kalle Valo
2017-05-12 15:43 ` Joe Perches [this message]
2017-05-12 16:37 ` Kalle Valo
2017-05-12 17:47 ` Igor Mitsyanko
2017-05-17 13:12 ` [PATCH v6] " Johannes Berg
2017-05-18 20:08 ` Sergey Matyukevich
2017-05-19 10:18 ` Johannes Berg
2017-05-21 17:08 ` Sergey Matyukevich
2017-05-22 6:28 ` Johannes Berg
2017-05-22 21:04 ` Sergey Matyukevich
2017-05-24 7:11 ` Johannes Berg
2017-05-24 11:08 ` Sergey Matyukevich
2017-05-22 9:09 ` Kalle Valo
2017-05-24 14:06 ` [v6] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494603783.2028.21.camel@perches.com \
--to=joe@perches.com \
--cc=avinashp@quantenna.com \
--cc=btherthala@quantenna.com \
--cc=dlebed@quantenna.com \
--cc=hwang@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=johannes@sipsolutions.net \
--cc=krath@quantenna.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=smaksimenko@quantenna.com \
--cc=smatyukevich@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).