From: Johannes Berg <johannes@sipsolutions.net>
To: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
Cc: Jesse Jones <jjones@uniumwifi.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Alexis Green <agreen@cococorp.com>,
Alexis Green <agreen@uniumwifi.com>
Subject: Re: [PATCH v2] mac80211: mesh - always do every discovery retry
Date: Wed, 17 May 2017 15:59:27 +0200 [thread overview]
Message-ID: <1495029567.2442.18.camel@sipsolutions.net> (raw)
In-Reply-To: <CAEFj986RfzE_AjuO0woU9JLcaUPetRYfx1HTNa+MXfEyRWqTbA@mail.gmail.com> (sfid-20170329_123356_020574_F9F8F5DD)
On Wed, 2017-03-29 at 18:33 +0800, Chun-Yeow Yeoh wrote:
> I would suggest the following modification of commit messages and
> code. Let me know whether this is fine.
>
> ---------
> I would suggest the following edition to the commit message:
>
> Instead of stopping path discovery when a path is established,
> continue the
> attempts to find alternative paths until we hit the
> dot11MeshHWMPmaxPREQretries
> limit. However, this is not a standard behavior and may easily
> increase the number of
> broadcast PREQ frame in your network. So this feature is turned off
> by default.
>
> and the remaining are removed due to misleading explanation.
>
> Then, in the mesh_path_timer, I think that only the following is
> needed:
>
> - if (mpath->flags & MESH_PATH_RESOLVED ||
> - (!(mpath->flags & MESH_PATH_RESOLVING))) {
> + if (!multiple_discoveries &&
> + (mpath->flags & MESH_PATH_RESOLVED ||
> + (!(mpath->flags & MESH_PATH_RESOLVING)))) {
Alexis?
johannes
next prev parent reply other threads:[~2017-05-17 13:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 1:28 [PATCH v2] mac80211: mesh - always do every discovery retry Chun-Yeow Yeoh
2017-03-02 17:32 ` Jesse Jones
2017-03-03 10:39 ` Chun-Yeow Yeoh
2017-03-03 18:49 ` Jesse Jones
[not found] ` <CAEFj987m=5a6pWZLMtTcVshmVfOmwwbb-+s0FR_+Dz6_xx7Dtw@mail.gmail.com>
2017-03-04 12:05 ` Chun-Yeow Yeoh
2017-03-06 18:25 ` Jesse Jones
2017-03-07 2:06 ` Chun-Yeow Yeoh
2017-03-29 8:24 ` Johannes Berg
2017-03-29 10:33 ` Chun-Yeow Yeoh
2017-05-17 13:59 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-02-28 23:50 Alexis Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495029567.2442.18.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=agreen@cococorp.com \
--cc=agreen@uniumwifi.com \
--cc=jjones@uniumwifi.com \
--cc=linux-wireless@vger.kernel.org \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).