Re: [PATCH v6] qtnfmac: introduce new FullMAC driver for Quantenna chipsets

[Johannes Berg <johannes@sipsolutions.net>]

Hi,

> Thanks for the review ! Fixes will be queued to the upcoming patches
> with various cleanups as well as new features.

Great :)

FWIW, regarding the  qtnf_mgmt_frame_register() and
cfg80211_rx_mgmt() thing, I think we'll have to discuss how to do this,
and perhaps you need to think about the firmware API for it.

Right now, I don't see that you can pass filters down, but you probably
also don't want to implement the reject code in the driver? And
cfg80211 doesn't give you that data right now either... So somewhere I
expect we'll need to make changes, unless you just copy (e.g. from
mac80211) the implementation of what happens when cfg80211_rx_mgmt()
returns false.

> BTW, speaking about other backends... During previous reviews of this
> patch we had a question regarding possible support of another
> previous generation SoC connected to host CPU via RGMII interface. Is
> there any legitimate (aka 'upstreamable') way to support such
> wireless cards ?

I'm not really familiar with RGMII, so I can't say how you'd support
this, sorry.

johannes