Fw: [Bug 195953] New: Possible access to unintended variable in "linux/net/mac80211/sta_info.c" line 2158

Fw: [Bug 195953] New: Possible access to unintended variable in "linux/net/mac80211/sta_info.c" line 2158

[Stephen Hemminger]

Begin forwarded message:

Date: Thu, 01 Jun 2017 06:55:22 +0000
From: bugzilla-daemon@bugzilla.kernel.org
To: stephen@networkplumber.org
Subject: [Bug 195953] New: Possible access to unintended variable in "linux/net/mac80211/sta_info.c" line 2158


https://bugzilla.kernel.org/show_bug.cgi?id=195953

            Bug ID: 195953
           Summary: Possible access to unintended variable in
                    "linux/net/mac80211/sta_info.c" line 2158
           Product: Networking
           Version: 2.5
    Kernel Version: 4.12-rc3
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Other
          Assignee: stephen@networkplumber.org
          Reporter: petrum@gmail.com
        Regression: No

While experimenting with a CodeSonar plugin we develop, we noticed a
potential issue in file "linux/net/mac80211/sta_info.c" line 2158 function
sta_set_sinfo

        sinfo->rx_dropped_misc = sta->rx_stats.dropped;
        if (sta->pcpu_rx_stats) {
                for_each_possible_cpu(cpu) {
                        struct ieee80211_sta_rx_stats *cpurxs;

                        cpurxs = per_cpu_ptr(sta->pcpu_rx_stats, cpu);
        /*HERE*/        sinfo->rx_packets += cpurxs->dropped;
                }
        }

Wasn't the intention to use "rx_dropped_misc" (instead of "rx_packets") in the
indicated line. In the first line, "rx_dropped_misc" is updated.

Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Fw: [Bug 195953] New: Possible access to unintended variable in "linux/net/mac80211/sta_info.c" line 2158

[Johannes Berg]

Thanks Stephen, I'll take the bug and fix it.

johannes