From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>, linux-wireless@vger.kernel.org
Cc: nbd@nbd.name
Subject: Re: [RFC 3/6] mac80211: add a TXQ for other powersave-buffered frames
Date: Fri, 23 Jun 2017 11:21:40 +0200 [thread overview]
Message-ID: <1498209700.2595.2.camel@sipsolutions.net> (raw)
In-Reply-To: <3735eb1d-89b5-b4ad-6657-d0d4e9642574@candelatech.com>
On Thu, 2017-06-22 at 07:43 -0700, Ben Greear wrote:
>
> On 06/21/2017 11:24 PM, Johannes Berg wrote:
> > On Wed, 2017-06-21 at 17:02 -0700, Ben Greear wrote:
> > > I think a comment for the above code block would be warranted
> > > (and
> > > for ath10k as well).
> > >
> > > I guess this is the part about dequeueing the frames immediately?
> >
> > Yeah, I figured it was pretty obvious, but I can add a comment :)
>
> It is fairly obvious today, but 6 months from now when someone tries
> yet again to figure out WTF is ath10k doing, it will be one more
> piece of mystery code!
:-)
Turns out this won't work well, I had misunderstood the TXQ code.
We do need queueing for these frames, we just do it on the pending
thing in mac80211... that's rather awful, and means we have to
integrate much deeper with ath9k/ath10k to make any progress here.
johannes
next prev parent reply other threads:[~2017-06-23 9:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 23:50 [RFC 1/6] mac80211: agg-tx: call drv_wake_tx_queue in proper context Johannes Berg
2017-06-21 23:50 ` [RFC 2/6] mac80211: fix VLAN handling with TXQs Johannes Berg
2017-06-21 23:50 ` [RFC 3/6] mac80211: add a TXQ for other powersave-buffered frames Johannes Berg
2017-06-22 0:02 ` Ben Greear
2017-06-22 6:24 ` Johannes Berg
2017-06-22 14:43 ` Ben Greear
2017-06-23 9:21 ` Johannes Berg [this message]
2017-06-23 12:27 ` Ben Greear
2017-06-26 11:00 ` Johannes Berg
2017-06-26 14:15 ` Ben Greear
2017-06-26 14:27 ` Johannes Berg
2017-06-21 23:50 ` [RFC 4/6] mac80211: don't put null-data frames on the normal TXQ Johannes Berg
2017-06-21 23:50 ` [RFC 5/6] mac80211: add a general fallback TXQ Johannes Berg
2017-06-22 8:48 ` Johannes Berg
2017-06-21 23:50 ` [RFC 6/6] mac80211: always go through txqs Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498209700.2595.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).