From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>, linux-wireless@vger.kernel.org
Cc: nbd@nbd.name
Subject: Re: [RFC 3/6] mac80211: add a TXQ for other powersave-buffered frames
Date: Mon, 26 Jun 2017 13:00:26 +0200 [thread overview]
Message-ID: <1498474826.3318.4.camel@sipsolutions.net> (raw)
In-Reply-To: <89353e7a-5c61-eba3-fe34-0e7eadf7588e@candelatech.com>
On Fri, 2017-06-23 at 05:27 -0700, Ben Greear wrote:
> I don't understand the code well enough to know if this matters or
> not, but the ath10k wave-2 stuff has some txq prefetch logic in the
> firmware (and support in the driver). But, it doesn't prefetch for
> the mgt tid as far as I can tell. It somehow all mostly works
> anyway, but possibly this would have some effect on your
> changes. wave-1 (QCA 9880, etc) doesn't do txq prefetch at all. Any
> tricky changes to this logic would need to test with both chipsets.
I don't think this matters. The issue at hand is that the driver still
relies on mac80211 buffering.
This *can* be solved, even in this piece of code I inserted here, but
it'd have to keep state about the queues and then insert some hooks
elsewhere. I'm pretty sure I can solve that, but don't have the time
(or even hardware) to test this (easily, I have ath10k in a few
routers, but ...).
johannes
next prev parent reply other threads:[~2017-06-26 11:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 23:50 [RFC 1/6] mac80211: agg-tx: call drv_wake_tx_queue in proper context Johannes Berg
2017-06-21 23:50 ` [RFC 2/6] mac80211: fix VLAN handling with TXQs Johannes Berg
2017-06-21 23:50 ` [RFC 3/6] mac80211: add a TXQ for other powersave-buffered frames Johannes Berg
2017-06-22 0:02 ` Ben Greear
2017-06-22 6:24 ` Johannes Berg
2017-06-22 14:43 ` Ben Greear
2017-06-23 9:21 ` Johannes Berg
2017-06-23 12:27 ` Ben Greear
2017-06-26 11:00 ` Johannes Berg [this message]
2017-06-26 14:15 ` Ben Greear
2017-06-26 14:27 ` Johannes Berg
2017-06-21 23:50 ` [RFC 4/6] mac80211: don't put null-data frames on the normal TXQ Johannes Berg
2017-06-21 23:50 ` [RFC 5/6] mac80211: add a general fallback TXQ Johannes Berg
2017-06-22 8:48 ` Johannes Berg
2017-06-21 23:50 ` [RFC 6/6] mac80211: always go through txqs Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498474826.3318.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).