From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtprelay0192.hostedemail.com ([216.40.44.192]:37618 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751495AbdF1TXl (ORCPT ); Wed, 28 Jun 2017 15:23:41 -0400 Message-ID: <1498677816.8633.4.camel@perches.com> (sfid-20170628_212350_950042_9B07B289) Subject: Re: [PATCH] mac80211_hwsim: use dyndbg for debug messages From: Joe Perches To: Lubomir Rintel , Johannes Berg Cc: Kalle Valo , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 28 Jun 2017 12:23:36 -0700 In-Reply-To: <1498677005.21787.1.camel@v3.sk> References: <20170628131726.15528-1-lkundrak@v3.sk> <1498662178.12531.6.camel@sipsolutions.net> <1498677005.21787.1.camel@v3.sk> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2017-06-28 at 21:10 +0200, Lubomir Rintel wrote: > On Wed, 2017-06-28 at 17:02 +0200, Johannes Berg wrote: > > On Wed, 2017-06-28 at 15:17 +0200, Lubomir Rintel wrote: > > > The mac80211_hwsim doesn't offer a way to disable the debugging > > > output. > > > Unfortunately, it's pretty chatty, dumping a lot of stuff into the > > > message buffer. > > > > Why is this a problem? It's pretty much a testing tool only, and much > > of the point is to have message about it's internal state? > > I do use it as a development tool. I find it very convenient to always > have a bunch of libvirt-managed LXC containers, some running hostapd > instances with various access point configurations and some used for > NetworkManager development and a mac80211_hwsim radio in each of them. > > An unfortunate side-effect is that my dmesg becomes next to useless due > to the overwhelming amount of mac80211_hwsim logging. Perhaps convert some of these to debugfs output? Otherwise, many or most of these seem to be function tracing type calls that could or should use ftrace.