From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jouni@qca.qualcomm.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Srinivas Dasari <dasaris@qti.qualcomm.com>
Subject: Re: [PATCH 1/4] cfg80211: Check if PMKID attribute is of expected size
Date: Fri, 07 Jul 2017 13:41:51 +0200 [thread overview]
Message-ID: <1499427711.4790.4.camel@sipsolutions.net> (raw)
In-Reply-To: <20170707093612.GA5732@jouni.qca.qualcomm.com>
On Fri, 2017-07-07 at 09:36 +0000, Jouni Malinen wrote:
> On Fri, Jul 07, 2017 at 11:27:56AM +0200, Johannes Berg wrote:
> > All applied, thanks.
> >
> > How did you find these? Some of them go way back, after all, and I
> > don't think even coverity flagged them?
>
> Through manual review of all the nl80211 attributes.. There have been
> somewhat similar issues flagged as security issues in various kernel
> components recently and that has triggered more scrutiny for the
> kernel interfaces.
Cool, thanks for that. I almost thought (hoped?) you had a (new) tool
to detect this :)
johannes
prev parent reply other threads:[~2017-07-07 11:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 22:43 [PATCH 1/4] cfg80211: Check if PMKID attribute is of expected size Jouni Malinen
2017-07-06 22:43 ` [PATCH 2/4] cfg80211: Check if NAN service ID " Jouni Malinen
2017-07-06 22:43 ` [PATCH 3/4] cfg80211: Define nla_policy for NL80211_ATTR_LOCAL_MESH_POWER_MODE Jouni Malinen
2017-07-06 22:43 ` [PATCH 4/4] cfg80211: Validate frequencies nested in NL80211_ATTR_SCAN_FREQUENCIES Jouni Malinen
2017-07-07 9:27 ` [PATCH 1/4] cfg80211: Check if PMKID attribute is of expected size Johannes Berg
2017-07-07 9:36 ` Jouni Malinen
2017-07-07 11:41 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499427711.4790.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dasaris@qti.qualcomm.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).