From: Govind Singh <govinds@codeaurora.org>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: bjorn.andersson@linaro.org, david.brown@linaro.org,
andy.gross@linaro.org, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 0/6] *** Add support for wifi QMI client handshakes ***
Date: Mon, 23 Jul 2018 18:08:41 +0530 [thread overview]
Message-ID: <14acf06c481a2fd077ccc0823bd6e046@codeaurora.org> (raw)
In-Reply-To: <20180719175105.GA2633@centauri.lan>
Hi Niklas,
Thanks for the review.
On 2018-07-19 23:21, Niklas Cassel wrote:
> On Fri, Jul 06, 2018 at 02:26:17PM +0530, Govind Singh wrote:
>> Add QMI client handshakes for Q6 integrated WLAN connectivity
>> subsystem.
>> This module is responsible for communicating WLAN control messages to
>> FW
>> over QMI interface. This patch series enables the qmi handshakes
>> required for
>> WCN3990 chipset.
>
> (cut)
>
> Hello Govind,
>
> I ran make W=1, sparse, and checkpatch on your new iteration of
> patches.
> (I didn't do a full manual review this time, since I did that last
> time.)
>
> Building with warnings and checkpatch looks good,
> but sparse reports the two following warnings:
>
> CHECK drivers/net/wireless/ath/ath10k//qmi.c
> drivers/net/wireless/ath/ath10k//qmi.c:935:29: warning: incorrect type
> in assignment (different address spaces)
> drivers/net/wireless/ath/ath10k//qmi.c:935:29: expected void *msa_va
> drivers/net/wireless/ath/ath10k//qmi.c:935:29: got void [noderef]
> <asn:2>*
>
Fixed in v4 version.
> and
>
> drivers/net/wireless/ath/ath10k//snoc.c:76:22: warning: incorrect type
> in initializer (different base types)
> drivers/net/wireless/ath/ath10k//snoc.c:76:22: expected restricted
> __le16 [usertype] reg_offset
> drivers/net/wireless/ath/ath10k//snoc.c:76:22: got int
> drivers/net/wireless/ath/ath10k//snoc.c:77:19: warning: incorrect type
> in initializer (different base types)
> drivers/net/wireless/ath/ath10k//snoc.c:77:19: expected restricted
> __le16 [usertype] ce_id
> drivers/net/wireless/ath/ath10k//snoc.c:77:19: got int
> drivers/net/wireless/ath/ath10k//snoc.c:77:22: warning: incorrect type
> in initializer (different base types)
> drivers/net/wireless/ath/ath10k//snoc.c:77:22: expected restricted
> __le16 [usertype] reg_offset
> drivers/net/wireless/ath/ath10k//snoc.c:77:22: got int
> drivers/net/wireless/ath/ath10k//snoc.c:78:19: warning: incorrect type
> in initializer (different base types)
> drivers/net/wireless/ath/ath10k//snoc.c:78:19: expected restricted
Fixed in v4 version.
Thanks,
Govind
prev parent reply other threads:[~2018-07-23 13:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 8:56 [PATCH v3 0/6] *** Add support for wifi QMI client handshakes *** Govind Singh
2018-07-06 8:56 ` [PATCH v3 1/6] ath10k: Add qmi service helpers for wcn3990 qmi client Govind Singh
2018-07-06 8:56 ` [PATCH v3 2/6] ath10k: Add support to create boardname for non-bmi target Govind Singh
2018-07-10 23:40 ` Brian Norris
2018-07-06 8:56 ` [PATCH v3 4/6] firmware: qcom: scm: Add WLAN VMID for Qualcomm SCM interface Govind Singh
2018-07-06 8:56 ` [PATCH v3 5/6] ath10k: Add debug mask for QMI layer Govind Singh
2018-07-06 8:56 ` [PATCH v3 6/6] ath10k: Add QMI message handshake for wcn3990 client Govind Singh
2018-07-11 1:26 ` [PATCH v3 0/6] *** Add support for wifi QMI client handshakes *** Brian Norris
2018-07-11 2:24 ` Bjorn Andersson
2018-07-11 5:01 ` Govind Singh
2018-07-11 21:51 ` Brian Norris
2018-07-19 17:51 ` Niklas Cassel
2018-07-23 12:38 ` Govind Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14acf06c481a2fd077ccc0823bd6e046@codeaurora.org \
--to=govinds@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=ath10k@lists.infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).