From: Dan Williams <dcbw@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: james@nurealm.net, futur.andy@googlemail.com,
kvalo@codeaurora.org, arend.vanspriel@broadcom.com,
maheshb@google.com, andy@greyhouse.net, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, greearb@candelatech.com
Subject: Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers
Date: Wed, 16 Aug 2017 21:11:47 -0500 [thread overview]
Message-ID: <1502935907.30484.4.camel@redhat.com> (raw)
In-Reply-To: <20170816.143116.1172751167543812070.davem@davemloft.net>
On Wed, 2017-08-16 at 14:31 -0700, David Miller wrote:
> From: Dan Williams <dcbw@redhat.com>
> Date: Wed, 16 Aug 2017 16:22:41 -0500
>
> > My biggest suggestion is that perhaps bonding should grow
> hysteresis
> > for link speeds. Since WiFi can change speed every packet, you
> probably
> > don't want the bond characteristics changing every couple seconds
> just
> > in case your WiFi link is jumping around. Ethernet won't bounce
> around
> > that much, so the hysteresis would have no effect there. Or, if
> people
> > are concerned about response time to speed changes on ethernet
> (where
> > you probably do want an instant switch-over) some new flag to
> indicate
> > that certain devices don't have stable speeds over time.
>
> Or just report the average of the range the wireless link can hit,
> and
> be done with it.
>
> I think you guys are overcomplicating things.
That range can be from 1 to > 800Mb/s. No, it won't usually be all
over that range, but it won't be uncommon to fluctuate by hundreds of
Mb/s. I'm not sure a simple average is really the answer here. Even
doing that would require new knobs to ethtool, since the rate depends
heavily on card capabilities and also what AP you're connected to *at
that moment*. If you roam to another AP, then the max speed can
certainly change.
You'll probably say "aim for the 75% case" or something like that,
which is fine, but then you're depending on your 75% case to be (a)
single AP, (b) never move (eg, only bond wifi + ethernet), (c) little
radio interference. I'm not sure I'd buy that. If I've put words in
your mouth, forgive me.
Dan
next prev parent reply other threads:[~2017-08-17 2:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 5:39 Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers Kalle Valo
2017-08-10 12:43 ` Arend van Spriel
2017-08-10 17:52 ` Andreas Born
2017-08-11 13:14 ` Kalle Valo
2017-08-12 7:35 ` Kalle Valo
2017-08-12 19:30 ` James Feeney
2017-08-13 17:42 ` Andreas Born
2017-08-16 20:44 ` James Feeney
2017-08-16 21:01 ` David Miller
2017-08-16 21:22 ` Dan Williams
2017-08-16 21:31 ` David Miller
2017-08-17 2:11 ` Dan Williams [this message]
2017-08-17 2:36 ` Ben Greear
2017-08-17 3:18 ` Dan Williams
2017-08-17 3:32 ` Ben Greear
2017-08-17 2:42 ` David Miller
2017-08-17 5:33 ` Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502935907.30484.4.camel@redhat.com \
--to=dcbw@redhat.com \
--cc=andy@greyhouse.net \
--cc=arend.vanspriel@broadcom.com \
--cc=davem@davemloft.net \
--cc=futur.andy@googlemail.com \
--cc=greearb@candelatech.com \
--cc=james@nurealm.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).