From: Joe Perches <joe@perches.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Luca Coelho <luca@coelho.fi>,
linux-wireless@vger.kernel.org,
Liad Kaufman <liad.kaufman@intel.com>
Subject: Re: [PATCH 1/2] iwlwifi: fix long debug print
Date: Fri, 01 Sep 2017 01:21:23 -0700 [thread overview]
Message-ID: <1504254083.2361.7.camel@perches.com> (raw)
In-Reply-To: <87k21irg1g.fsf@kamboji.qca.qualcomm.com>
On Fri, 2017-09-01 at 11:15 +0300, Kalle Valo wrote:
> Joe Perches <joe@perches.com> writes:
> > On Fri, 2017-09-01 at 08:37 +0300, Luca Coelho wrote:
> > > On Thu, 2017-08-31 at 14:57 -0700, Joe Perches wrote:
> > > > On Fri, 2017-08-25 at 11:27 +0300, Luca Coelho wrote:
> > > > > From: Liad Kaufman <liad.kaufman@intel.com>
> > > > > There is a debug print that sometimes reaches over
> > > > > 110 chars, thus generating a warning in those cases.
[]
> > It might make sense to add a comment to describe these
> > trace events coming from TRACE_EVENT(iwlwifi_dbg,
> >
> > All the IWL_DEBUG_<foo> use this trace message maximum.
>
> Unfortunately the patch is already commited to wireless-drivers-next so
> we can't change the commit log anymore.
No worries about the commit.
It'd be useful to add a comment to the code.
next prev parent reply other threads:[~2017-09-01 8:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 8:27 [PATCH 0/2] iwlwifi: updates intended for v4.14 2017-08-25 Luca Coelho
2017-08-25 8:27 ` [PATCH 1/2] iwlwifi: fix long debug print Luca Coelho
2017-08-31 21:57 ` Joe Perches
2017-09-01 5:37 ` Luca Coelho
2017-09-01 6:15 ` Joe Perches
2017-09-01 8:15 ` Kalle Valo
2017-09-01 8:21 ` Joe Perches [this message]
2017-08-25 8:27 ` [PATCH 2/2] iwlwifi: mvm: Avoid deffering non bufferable frames Luca Coelho
2017-08-29 8:22 ` Kalle Valo
2017-08-30 7:32 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504254083.2361.7.camel@perches.com \
--to=joe@perches.com \
--cc=kvalo@codeaurora.org \
--cc=liad.kaufman@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).