From: Johannes Berg <johannes@sipsolutions.net>
To: amit.khatri@samsung.com
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Nitin Jhanwar <nitin.j@samsung.com>
Subject: Re: [PATCH] iw: Null check before accessing n_mcs variable
Date: Wed, 06 Sep 2017 12:39:03 +0200 [thread overview]
Message-ID: <1504694343.13457.11.camel@sipsolutions.net> (raw)
In-Reply-To: <20170901061008epcms5p5fdd787910f9698c511e01a134afe90ea@epcms5p5>
On Fri, 2017-09-01 at 06:10 +0000, Amit Khatri wrote:
> From: Amit Khatri <amit.khatri@samsung.com>
> Date: Thu, 24 Aug 2017 00:16:26 -0700
> Subject: [PATCH] iw: Null check before accessing n_mcs variable
>
> If all cases will fail n_mcs variable fail to get any assignement
> and remain NULL. so better to check NULL before dereference.
>
This is wrong - you can't get into S_HT state unless n_mcs was also
assigned, and if you can't get into S_HT state then you can't
dereference n_mcs either.
johannes
prev parent reply other threads:[~2017-09-06 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170901061008epcms5p5fdd787910f9698c511e01a134afe90ea@epcms5p5>
2017-09-01 6:10 ` [PATCH] iw: Null check before accessing n_mcs variable Amit Khatri
2017-09-06 10:39 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504694343.13457.11.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=amit.khatri@samsung.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nitin.j@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox