From: Johannes Berg <johannes@sipsolutions.net>
To: Benjamin Beichler <benjamin.beichler@uni-rostock.de>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC 4/4] mac80211_hwsim: add radio idx param to netlink callback of radio creation
Date: Fri, 08 Sep 2017 16:28:06 +0200 [thread overview]
Message-ID: <1504880886.20347.4.camel@sipsolutions.net> (raw)
In-Reply-To: <c6eda3a2-ad9b-4c33-b3c8-ddc36199ea3e@MAIL1.uni-rostock.de>
On Fri, 2017-09-08 at 16:11 +0200, Benjamin Beichler wrote:
> Since the radio index is already a valid NL attribute, this patch
> simply
> try to read it and create the radio specific to this index by the
> previously used scheme.
>
> Since this allows to create radios out of row, we need to search for
> a
> free index for a new radio, when the index is not present as
> parameter.
This seems like a bad idea, what's the point? You can always change the
MAC address later if you want.
Also, you don't seem to actually do what you said, with the -1.
johannes
next prev parent reply other threads:[~2017-09-08 14:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170908141137.3941-1-benjamin.beichler@uni-rostock.de>
2017-09-08 14:11 ` [RFC 2/4] mac80211_hwsim: add hwsim_tx_rate_flags to Netlink Attributes Benjamin Beichler
2017-09-08 14:26 ` Johannes Berg
2017-09-11 9:49 ` Benjamin Beichler
2017-09-15 7:36 ` Johannes Berg
2017-09-08 14:11 ` [RFC 3/4] mac80211_hwsim: explicitly set netlink parallel ops to false Benjamin Beichler
2017-09-08 14:19 ` Johannes Berg
2017-09-08 15:07 ` Benjamin Beichler
2017-09-08 15:11 ` Johannes Berg
2017-09-08 14:11 ` [RFC 4/4] mac80211_hwsim: add radio idx param to netlink callback of radio creation Benjamin Beichler
2017-09-08 14:28 ` Johannes Berg [this message]
2017-09-08 14:43 ` Benjamin Beichler
2017-09-08 14:46 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504880886.20347.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=benjamin.beichler@uni-rostock.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).