From: Johannes Berg <johannes@sipsolutions.net>
To: Benjamin Beichler <benjamin.beichler@uni-rostock.de>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC 3/4] mac80211_hwsim: explicitly set netlink parallel ops to false
Date: Fri, 08 Sep 2017 17:11:18 +0200 [thread overview]
Message-ID: <1504883478.20347.7.camel@sipsolutions.net> (raw)
In-Reply-To: <5BB75376-46E0-45F4-8886-C90CEA37CB2B@uni-rostock.de>
On Fri, 2017-09-08 at 17:07 +0200, Benjamin Beichler wrote:
>
> Am 8. September 2017 16:19:20 MESZ schrieb Johannes Berg <johannes@si
> psolutions.net>:
> > On Fri, 2017-09-08 at 16:11 +0200, Benjamin Beichler wrote:
> > > The ops field is zero initialized, therefore parallel ops is
> > > already
> > > false.
> >
> > Therefore this patch is completely pointless?
>
> Sorry my first message was missing regarding this. My question is,
> whether this is intentionally, and if it is parallel, whether we need
> extensive locking here.
It's basically intentional - not sure parallel_ops even existed when
this was first written, but we can probably use parallel_ops if we want
to.
johannes
next prev parent reply other threads:[~2017-09-08 15:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170908141137.3941-1-benjamin.beichler@uni-rostock.de>
2017-09-08 14:11 ` [RFC 2/4] mac80211_hwsim: add hwsim_tx_rate_flags to Netlink Attributes Benjamin Beichler
2017-09-08 14:26 ` Johannes Berg
2017-09-11 9:49 ` Benjamin Beichler
2017-09-15 7:36 ` Johannes Berg
2017-09-08 14:11 ` [RFC 3/4] mac80211_hwsim: explicitly set netlink parallel ops to false Benjamin Beichler
2017-09-08 14:19 ` Johannes Berg
2017-09-08 15:07 ` Benjamin Beichler
2017-09-08 15:11 ` Johannes Berg [this message]
2017-09-08 14:11 ` [RFC 4/4] mac80211_hwsim: add radio idx param to netlink callback of radio creation Benjamin Beichler
2017-09-08 14:28 ` Johannes Berg
2017-09-08 14:43 ` Benjamin Beichler
2017-09-08 14:46 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504883478.20347.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=benjamin.beichler@uni-rostock.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).