linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>,
	Arend van Spriel <arend.vanspriel@broadcom.com>,
	Arend van Spriel <arend@broadcom.com>, Jouni Malinen <j@w1.fi>
Cc: Avraham Stern <avraham.stern@intel.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: ROAM/CONNECT event with PORT_AUTHORIZED
Date: Thu, 14 Sep 2017 21:17:38 +0200	[thread overview]
Message-ID: <1505416658.31630.15.camel@sipsolutions.net> (raw)
In-Reply-To: <e418234f-00a0-dd44-7352-d279f49f83e5@gmail.com> (sfid-20170914_203757_701557_A7A3EC0F)

On Thu, 2017-09-14 at 13:37 -0500, Denis Kenzior wrote:

> The question is whether all APs are actually sane after a
> roam.  E.g. can the STA assume that the same IP address, DHCP lease,
> etc is still valid?  I heard from various people that this might not
> be the case, but we haven't had a chance to verify those claims...

I think you pretty much have to assume that, otherwise there's no point
in roaming at all - you want your connections to stay, possibly voice
calls to continue, etc.

> I think it does make sense to tie one into the other.  However, do
> we have a race condition here?  E.g. AUTHORIZED is sent on one
> socket, then OPER_STATE is signaled on rtnl.  Which one do
> applications rely on?

Regular applications wouldn't really look at nl80211.

> > Note that we *can't* do this right now, otherwise we can't transfer
> > the EAPOL frames; but once we do that over nl80211 we'd be able to.

However, I'm not really convinced (any more) that this is actually
correct. If I'm reading the supplicant code correctly, then it sets
IF_OPER_UP only once the connection is *completed*, so it's already
doing what I thought it should be doing and couldn't.

> *wakes up*
> 
> Ah I now seem to remember that I volunteered to look into this before
> my sabbatical :)  I think this was in early June?  I'm certainly
> still interested in doing so.   Let me dust off that portion of my
> brain and come up with a proposal.  Unless you already have a clear
> idea of how things should work?

Not really. I guess a new command/event with the frame, and some flags,
I know that at least we want a "don't encrypt" flag, for example.

johannes

  reply	other threads:[~2017-09-14 19:17 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-14  8:39 ROAM/CONNECT event with PORT_AUTHORIZED Johannes Berg
2017-09-14 11:21 ` Arend van Spriel
2017-09-14 11:44   ` Johannes Berg
2017-09-14 18:37     ` Denis Kenzior
2017-09-14 19:17       ` Johannes Berg [this message]
2017-09-14 19:34         ` Denis Kenzior
2017-09-14 19:38           ` Ben Greear
2017-09-14 20:05             ` Denis Kenzior
2017-09-14 20:08               ` Ben Greear
2017-09-14 20:26                 ` Denis Kenzior
2017-09-14 20:29                   ` Ben Greear
2017-09-14 20:35                     ` Denis Kenzior
2017-09-14 20:47                       ` Ben Greear
2017-09-14 21:35                         ` Denis Kenzior
2017-09-14 22:15                           ` Ben Greear
2017-09-14 22:42                             ` Denis Kenzior
2017-09-14 22:57                               ` Ben Greear
2017-09-15  7:23                                 ` Johannes Berg
2017-09-15  7:20                         ` Johannes Berg
2017-09-14 19:39           ` Johannes Berg
2017-09-14 18:27 ` Denis Kenzior
2017-09-14 18:36   ` Johannes Berg
2017-09-14 19:08     ` Denis Kenzior
2017-09-14 19:22       ` Johannes Berg
2017-09-14 19:37         ` Denis Kenzior
2017-09-14 19:41           ` Johannes Berg
2017-09-14 19:42             ` Johannes Berg
2017-09-14 19:54             ` Denis Kenzior
2017-09-15  7:19               ` Johannes Berg
2017-09-15 12:50                 ` Denis Kenzior
2017-09-15 13:29                   ` Johannes Berg
2017-09-15 13:50                     ` Denis Kenzior
2017-09-15 14:20                       ` Johannes Berg
2017-09-15 14:27                         ` Denis Kenzior
2017-09-15 14:52                           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505416658.31630.15.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend.vanspriel@broadcom.com \
    --cc=arend@broadcom.com \
    --cc=avraham.stern@intel.com \
    --cc=denkenz@gmail.com \
    --cc=j@w1.fi \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).