Re: [PATCH 0/2] ath10k: Add support for QCA9887

[Sven Eckelmann <sven.eckelmann@open-mesh.com>]

[-- Attachment #1: Type: text/plain, Size: 2532 bytes --]

On Thursday 26 May 2016 17:32:30 Valo, Kalle wrote:
> Sven Eckelmann <sven.eckelmann@open-mesh.com> writes:
> 
> > the QCA9887 chip is similar to the QCA988x chips. But it requires a special
> > firmware and uses a different calibration data source. Unfortunately, no
> > working firmware currently exists. But it is possible to create a semi working
> > one by binary patching the current version.
> 
> So what works and what doesn't?

We currently stopped everything related to QCA9887 and so I cannot give you an
exhaustive list. But right now basic AP functionality seems to work. The
signal level, coverage and performance was rather bad. I cannot give you
numbers anymore because the two actual tests with QCA9887 were done 1 year ago
and 1/2 year ago (you know why ;) ).

But maybe I should add that the results with the original AP147 firmware also
wasn't better.

The hardware also doesn't seem to be able to produce spectral frame results.
It is unknown whether it uses an incompatible format or whether the
firmware/hardware is just not capable to produce spectral results.

[...]
> I can upload a new version. So I need to add these flags:
> 
> ATH10K_FW_FEATURE_HAS_WMI_MGMT_TX
> ATH10K_FW_FEATURE_NO_P2P
> ATH10K_FW_FEATURE_SUPPORTS_SKIP_CLOCK_INIT
> 
> Anything else?

At least I didn't find more. Possible that more are needed - I would guess
that the question to the QCA firmware team is still pending.

[...]
> Should we add a warning message to ath10k that the QCA9887 support is
> experimental? That way users don't need to wonder why there are so many
> problems.

Yes, this would be a good idea. I personally wouldn't know where you want
to have this warning added. So maybe you just add it? Thanks

> There were some conflicts in patch 1. I fixed those now and pushed the
> patches to the pending branch for further testing:
> 
> https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/log/?h=master-pending
> 
> Unfortunately I don't have QCA9887 myself so I can't test these myself.
> I hope I didn't break anything.

Ah, yes. The new patches "clean up growing hw checks during safe and full reset"
and some QCA9884 stuff seems to have created some conflicts. I have redone my
patches on top of them and compared with your solution. We came up with the
exact same conflict resolution. So you can at least say that I would also
have broken it ;)

I have just created a compat-wireless based on your branch which I've tested
it with my QCA9887 test card. No new problems were detected.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]