From: Johannes Berg <johannes@sipsolutions.net>
To: Kees Cook <keescook@chromium.org>, linux-wireless@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mac80211: aggregation: Convert timers to use timer_setup()
Date: Wed, 18 Oct 2017 13:31:31 +0200 [thread overview]
Message-ID: <1508326291.2674.21.camel@sipsolutions.net> (raw)
In-Reply-To: <1508322566.2674.17.camel@sipsolutions.net> (sfid-20171018_122945_123971_5A96CA64)
On Wed, 2017-10-18 at 12:29 +0200, Johannes Berg wrote:
> Anyway, the change here looks correct to me, so I'll apply it and then
> perhaps clean up more. I've only changed "u16 tid" to "u8 tid" since
> the valid range is 0-15 (in theory, in practice 0-7).
Well, I guess I'm clearly wrong - it's crashing our test suite left and
right.
I'll dig a little bit, but I don't have much time today, and will be
out for a few days starting tomorrow.
johannes
next prev parent reply other threads:[~2017-10-18 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 20:25 [PATCH] mac80211: aggregation: Convert timers to use timer_setup() Kees Cook
2017-10-18 10:29 ` Johannes Berg
2017-10-18 11:31 ` Johannes Berg [this message]
2017-10-18 11:37 ` Johannes Berg
2017-10-18 14:17 ` Kees Cook
2017-10-18 14:19 ` Kees Cook
2017-10-18 20:50 ` Johannes Berg
2017-10-18 21:02 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508326291.2674.21.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).