From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, Maya Erez <qca_merez@qca.qualcomm.com>
Subject: Re: wil6210: disallow changing RSN in beacon change
Date: Fri, 27 Oct 2017 15:45:47 +0200 [thread overview]
Message-ID: <1509111947.2283.0.camel@sipsolutions.net> (raw)
In-Reply-To: <f48cbfcf31204a839d345927f712227f@euamsexm01a.eu.qualcomm.com>
On Fri, 2017-10-27 at 15:42 +0200, Kalle Valo wrote:
> Johannes Berg <johannes@sipsolutions.net> wrote:
>
> > This is a code path that will never really get hit anyway, since
> > it's nonsense to change the beacon of an existing BSS to suddenly
> > include or no longer include the RSN IE. Reject this instead of
> > having the dead code, and get rid of accessing wdev->ssid/_len by
> > way of that.
> >
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> > Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
>
> What's the conclusion, should I take this patch or drop it?
Drop, at least for now. I need to look into this and probably do things
in cfg80211.
johannes
prev parent reply other threads:[~2017-10-27 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 19:42 [PATCH] wil6210: disallow changing RSN in beacon change Johannes Berg
2017-10-18 9:25 ` Lior David
2017-10-18 10:13 ` Johannes Berg
2017-10-19 6:07 ` Lior David
2017-10-27 13:42 ` Kalle Valo
2017-10-27 13:45 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509111947.2283.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=qca_merez@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).