From: Johannes Berg <johannes@sipsolutions.net>
To: Peng Xu <pxu@qti.qualcomm.com>, Jouni Malinen <jouni@qca.qualcomm.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Sara Sharon <sara.sharon@intel.com>
Subject: Re: [RFC] cfg80211: Implement Multiple BSSID capability in scanning
Date: Tue, 14 Nov 2017 15:23:28 +0100 [thread overview]
Message-ID: <1510669408.2030.23.camel@sipsolutions.net> (raw)
In-Reply-To: <4927d2288442486788cd5b4d0492537a@NASANEXM01F.na.qualcomm.com>
On Tue, 2017-11-14 at 14:20 +0000, Peng Xu wrote:
> >
> > > + if (tmp_old[0] == WLAN_EID_VENDOR_SPECIFIC) {
> > > + if (!memcmp(tmp_old + 2, tmp + 2, 5)) {
> > > + /* same vendor ie, copy from new ie
> >
> > */
> > > + memcpy(pos, tmp, tmp[1] + 2);
> > > + pos += tmp[1] + 2;
> > > + } else {
> > > + memcpy(pos, tmp_old, tmp_old[1] +
> >
> > 2);
> > > + pos += tmp_old[1] + 2;
> >
> > This seems really strange. What's 5? Should it be 4, so you have
> > OUI+subelement ID?
> >
>
> It is OUI + type + subTye.
Ah, right, type/subtype.
Still, this is problematic, because there's nothing that says that the
vendor IE must have OUI + type + subtype, the spec only says OUI +
vendor specific data.
This may be right for the WFA/Microsoft OUI, but not necessary anything
else?
johannes
next prev parent reply other threads:[~2017-11-14 14:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 16:39 [RFC] cfg80211: Implement Multiple BSSID capability in scanning Jouni Malinen
2017-11-13 10:07 ` Johannes Berg
2017-11-14 12:58 ` Johannes Berg
2017-11-14 14:20 ` Peng Xu
2017-11-14 14:23 ` Johannes Berg [this message]
2017-11-14 14:29 ` Peng Xu
2017-11-14 14:33 ` Johannes Berg
2017-11-14 14:39 ` Peng Xu
2017-11-14 16:31 ` Jouni Malinen
2017-11-14 17:38 ` Peng Xu
2017-11-27 12:03 ` Johannes Berg
2017-11-27 19:14 ` Peng Xu
2017-11-27 21:46 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510669408.2030.23.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pxu@qti.qualcomm.com \
--cc=sara.sharon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).