Linux wireless drivers development
 help / color / mirror / Atom feed
From: venkat.prashanth2498@gmail.com
To: gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org
Cc: chaoming_li@realsil.com.cn, Larry.Finger@lwfinger.net,
	Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
Subject: [PATCH v3] rtlwifi:rtl8723ae:add the function name to the printouts
Date: Fri, 24 Nov 2017 17:11:20 +0530	[thread overview]
Message-ID: <1511523680-5033-1-git-send-email-venkat.prashanth2498@gmail.com> (raw)

From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>

Prefer and make it generic by using %s and __func__
to print function name

Change Log:

v2:
a. RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE, "\n");
The function name is not necessary in above code
according to conditions as mentioned in comments.

b. modified the commit message according
to suggested comments.

c. fixed the alignment issues.

v1:
a. Sign-off line is saperated from subject
line from earlier patch version.

Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
---
 drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
index f713c72..09c4e14 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
@@ -389,7 +389,7 @@ void rtl8723e_tx_fill_desc(struct ieee80211_hw *hw,

 	if (pci_dma_mapping_error(rtlpci->pdev, mapping)) {
 		RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
-			 "DMA mapping error\n");
+			 "%s():DMA mapping error\n", __func__);
 		return;
 	}
 	if (mac->opmode == NL80211_IFTYPE_STATION) {
@@ -498,7 +498,7 @@ void rtl8723e_tx_fill_desc(struct ieee80211_hw *hw,
 		if (ieee80211_is_data_qos(fc)) {
 			if (mac->rdg_en) {
 				RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
-				"Enable RDG function.\n");
+				"%s():Enable RDG function.\n", __func__);
 				SET_TX_DESC_RDG_ENABLE(pdesc, 1);
 				SET_TX_DESC_HTC(pdesc, 1);
 			}
@@ -557,7 +557,7 @@ void rtl8723e_tx_fill_cmddesc(struct ieee80211_hw *hw,

 	if (pci_dma_mapping_error(rtlpci->pdev, mapping)) {
 		RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
-			 "DMA mapping error\n");
+			 "%s():DMA mapping error\n", __func__);
 		return;
 	}
 	CLEAR_PCI_TX_DESC_CONTENT(pdesc, TX_DESC_SIZE);
--
1.9.1

             reply	other threads:[~2017-11-24 11:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-24 11:41 venkat.prashanth2498 [this message]
2017-11-24 11:47 ` [PATCH v3] rtlwifi:rtl8723ae:add the function name to the printouts Greg KH
2017-11-24 18:30 ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1511523680-5033-1-git-send-email-venkat.prashanth2498@gmail.com \
    --to=venkat.prashanth2498@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=chaoming_li@realsil.com.cn \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox