linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Peter Große" <pegro@friiks.de>, linux-wireless@vger.kernel.org
Subject: Re: Setting TX power on a monitoring interface
Date: Fri, 01 Dec 2017 15:49:02 +0100	[thread overview]
Message-ID: <1512139742.25588.14.camel@sipsolutions.net> (raw)
In-Reply-To: <20171127160722.4969cd23@friiks.de> (sfid-20171127_160737_710701_E5B0F542)

On Mon, 2017-11-27 at 16:07 +0100, Peter Große wrote:

> > I think if the driver has WANT_MONITOR_VIF, then we can pass that
> > through and let the driver sort it out.
> > 
> > But if not, we probably just have to reject the configuration?
> 
> With passing through you mean calling bss_info_changed on the driver for the
> monitor interface?

I meant to pass the &monitor_sdata.vif pointer instead of the real
monitor interface that's coming through cfg80211. The former is virtual
and has no netdev, but the diver is aware of it.

> Are monitor interfaces allowed to exist when WANT_MONITOR_VIF is not set?

Yes

> I ask, whether I would have to check 
>   sdata->vif.type == NL80211_IFTYPE_MONITOR
> _and_ also
>   ieee80211_hw_check(&local->hw, WANT_MONITOR_VIF)

You can check that

	local->monitor_sdata

exists, and use it if yes, and reject if no.

johannes

  reply	other threads:[~2017-12-01 14:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-20 16:34 Setting TX power on a monitoring interface Peter Große
2017-11-27 11:43 ` Johannes Berg
2017-11-27 15:07   ` Peter Große
2017-12-01 14:49     ` Johannes Berg [this message]
2017-12-01 17:34       ` Peter Große
2017-12-09 19:53         ` Johannes Berg
2017-12-13 17:29           ` [PATCH] mac80211: Fix setting TX power on monitor interfaces Peter Große
2017-12-19  9:53             ` Johannes Berg
2017-12-19 19:25               ` Peter Große

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512139742.25588.14.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pegro@friiks.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).