From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>,
Jouni Malinen <jouni@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org,
Srinivas Dasari <dasaris@qti.qualcomm.com>
Subject: Re: [PATCH v2 1/3] cfg80211/nl80211: Optional authentication offload to userspace
Date: Mon, 15 Jan 2018 13:22:35 +0100 [thread overview]
Message-ID: <1516018955.410.21.camel@sipsolutions.net> (raw)
In-Reply-To: <c2554a26-bbbc-3bd2-0091-06fc14e88946@gmail.com> (sfid-20180104_215955_609727_80A46600)
On Thu, 2018-01-04 at 14:59 -0600, Denis Kenzior wrote:
> So this implies userspace must pre-register for authentication
> management frames, correct? And other applications could register to
> receive these frames as well? Would it not be easier (and more secure)
> to simply forward these directly to the application that triggered
> CMD_CONNECT instead?
Only one will be able to register, so I think it's OK. We could even
check that it's registered already at CONNECT time, I guess.
> > + genlmsg_multicast_netns(&nl80211_fam, wiphy_net(&rdev->wiphy), msg, 0,
> > + NL80211_MCGRP_MLME, gfp);
>
> Is there a reason this is being multicast and not unicast to the
> application that triggered the CONNECT? Who else besides the supplicant
> daemon might find this information useful?
That's a good point, we should send this to the CONNECT owner (and thus
obviously also require that there is one).
johannes
prev parent reply other threads:[~2018-01-15 12:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 16:33 [PATCH v2 1/3] cfg80211/nl80211: Optional authentication offload to userspace Jouni Malinen
2017-12-22 16:33 ` [PATCH v2 2/3] nl80211: Allow SAE Authentication for NL80211_CMD_CONNECT Jouni Malinen
2018-01-04 14:48 ` Johannes Berg
2017-12-22 16:33 ` [PATCH v2 3/3] nl80211: Introduce scan flags to emphasize requested scan behavior Jouni Malinen
2018-01-04 14:50 ` Johannes Berg
2018-01-04 14:47 ` [PATCH v2 1/3] cfg80211/nl80211: Optional authentication offload to userspace Johannes Berg
2018-01-04 20:59 ` Denis Kenzior
2018-01-15 12:22 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516018955.410.21.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dasaris@qti.qualcomm.com \
--cc=denkenz@gmail.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).