From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [RFC v2 1/5] nl80211: Add CONTROL_PORT_OVER_NL80211 attribute
Date: Mon, 15 Jan 2018 13:58:35 +0100 [thread overview]
Message-ID: <1516021115.410.23.camel@sipsolutions.net> (raw)
In-Reply-To: <20180110170938.2341-2-denkenz@gmail.com> (sfid-20180110_180956_952258_12ECA7BD)
On Wed, 2018-01-10 at 11:09 -0600, Denis Kenzior wrote:
>
> + WIPHY_FLAG_CONTROL_PORT_OVER_NL80211 = BIT(25),
I think it'd be easier for everyone to just use an nl80211 extended
feature flag for this, then you also don't need this code:
> + if (info->attrs[NL80211_ATTR_CONTROL_PORT_OVER_NL80211]) {
> + if (!info->attrs[NL80211_ATTR_SOCKET_OWNER])
> + return -EINVAL;
> +
> + if (!(rdev->wiphy.flags & WIPHY_FLAG_CONTROL_PORT_OVER_NL80211))
> + return -EOPNOTSUPP;
> +
> + settings->control_port_over_nl80211 = true;
> + } else {
> + settings->control_port_over_nl80211 = false;
> + }
Nit: you don't really need the else branch.
johannes
next prev parent reply other threads:[~2018-01-15 12:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 17:09 [RFC v2 0/5] EAPoL over NL80211 Denis Kenzior
2018-01-10 17:09 ` [RFC v2 1/5] nl80211: Add CONTROL_PORT_OVER_NL80211 attribute Denis Kenzior
2018-01-15 12:58 ` Johannes Berg [this message]
2018-01-10 17:09 ` [RFC v2 2/5] nl80211: Add CMD_CONTROL_PORT_FRAME API Denis Kenzior
2018-01-15 13:04 ` Johannes Berg
2018-01-10 17:09 ` [RFC v2 3/5] mac80211: Send control port frames over nl80211 Denis Kenzior
2018-01-15 13:09 ` Johannes Berg
2018-01-15 15:24 ` Denis Kenzior
2018-01-16 13:33 ` Johannes Berg
2018-01-10 17:09 ` [RFC v2 4/5] nl80211: Implement TX of control port frames Denis Kenzior
2018-01-15 13:14 ` Johannes Berg
2018-01-15 16:03 ` Denis Kenzior
2018-01-16 13:32 ` Johannes Berg
2018-01-10 17:09 ` [RFC v2 5/5] mac80211: Add support for tx_control_port Denis Kenzior
2018-01-15 13:15 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516021115.410.23.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=denkenz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).