From: Johannes Berg <johannes@sipsolutions.net>
To: Venkateswara Naralasetty <vnaralas@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
Bhagavathi Perumal S <bperumal@codeaurora.org>
Subject: Re: [PATCH 1/2] cfg80211: Add tx ack signal attribute in sta info
Date: Mon, 22 Jan 2018 13:22:08 +0100 [thread overview]
Message-ID: <1516623728.2508.4.camel@sipsolutions.net> (raw)
In-Reply-To: <1516279208-16485-1-git-send-email-vnaralas@codeaurora.org>
On Thu, 2018-01-18 at 18:10 +0530, Venkateswara Naralasetty wrote:
> From: Bhagavathi Perumal S <bperumal@codeaurora.org>
>
> This patch provides support for users to get ack signal
> strength of last transmitted by introducing new attribute
> 'NL80211_STA_INFO_ACK_SIGNAL'.
No real objection to the patch itself, but you should say *why* you
need this, and I'm not really sure I see much point in having the
signal strength of the very last ACK frame?
At least provide reasoning so other drivers can decide whether to
implement it or not.
> + * @NL80211_STA_INFO_ACK_SIGNAL: signal strength of the last ACK frame(u8, dBm)
more like s8, really.
johannes
next prev parent reply other threads:[~2018-01-22 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 12:40 [PATCH 1/2] cfg80211: Add tx ack signal attribute in sta info Venkateswara Naralasetty
2018-01-22 12:22 ` Johannes Berg [this message]
2018-01-24 11:27 ` vnaralas
2018-01-30 7:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516623728.2508.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=bperumal@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vnaralas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).