From: Johannes Berg <johannes@sipsolutions.net>
To: tamizhr@codeaurora.org
Cc: linux-wireless@vger.kernel.org, tamizhr@qti.qualcomm.com,
Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Subject: Re: [PATCH 3/4] mac80211: enable setting cqm config for AP mode
Date: Mon, 22 Jan 2018 13:57:39 +0100 [thread overview]
Message-ID: <1516625859.2508.23.camel@sipsolutions.net> (raw)
In-Reply-To: <1516174276-16789-4-git-send-email-tamizhr@codeaurora.org>
On Wed, 2018-01-17 at 13:01 +0530, tamizhr@codeaurora.org wrote:
>
> +static void ieee80211_update_rssi_config(struct ieee80211_sub_if_data *sdata)
[...]
> + /* if AP, always tell the driver by checking beacon status */
> + if ((sdata->vif.type == NL80211_IFTYPE_AP ||
> + sdata->vif.type == NL80211_IFTYPE_AP_VLAN ||
> + sdata->vif.type == NL80211_IFTYPE_P2P_GO) &&
> + !sdata->vif.bss_conf.enable_beacon)
nit: that line with !sdata should be indented one less, it doesn't
belong into the parenthesized expression.
Again though, this relies on a driver feature bit to not confuse the
driver.
johannes
next prev parent reply other threads:[~2018-01-22 12:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 7:31 [PATCH 0/4] cfg80211/mac80211: cqm rssi config for AP mode tamizhr
2018-01-17 7:31 ` [PATCH 1/4] wireless: allow send peer mac in rssi cqm notify tamizhr
2018-01-22 12:56 ` Johannes Berg
2018-01-17 7:31 ` [PATCH 2/4] cfg80211: enable setting cqm config for AP mode tamizhr
2018-01-22 12:56 ` Johannes Berg
2018-01-22 13:01 ` Johannes Berg
2018-01-17 7:31 ` [PATCH 3/4] mac80211: " tamizhr
2018-01-22 12:57 ` Johannes Berg [this message]
2018-01-17 7:31 ` [PATCH 4/4] mac80211: implement cqm using rx data signal tamizhr
2018-01-22 13:01 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516625859.2508.23.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
--cc=tamizhr@codeaurora.org \
--cc=tamizhr@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).