From: Johannes Berg <johannes@sipsolutions.net>
To: Benjamin Beichler <Benjamin.Beichler@uni-rostock.de>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mac80211_hwsim: don't use WQ_MEM_RECLAIM
Date: Wed, 24 Jan 2018 11:46:26 +0100 [thread overview]
Message-ID: <1516790786.2508.43.camel@sipsolutions.net> (raw)
In-Reply-To: <7eb10bf1-7825-3dae-b813-d912e6670440@uni-rostock.de>
On Wed, 2018-01-24 at 10:39 +0100, Benjamin Beichler wrote:
> sorry for introducing that error, but I'm a bit confused by the
> workqueue documentation.
> My assumption was, that deleting hwsim radios is reclaiming memory, and
> since this queue does nothing else it would save/necessary to set this flag.
>
> Maybe a hint in the documentation, that a work item on a WQ_MEM_RECLAIM
> queue must not call flush of an !WQ_MEM_RECLAIM queue would be nice.
> Maybe it's kind of obvious, but there is also a reminder not to forget
> that flag, if a queue may have work items that reclaim memory
Yeah, honestly, I'm not really sure either. Clearly we can't set it,
but other drivers also set it...
I don't think it was *intended* for when you're freeing memory, since I
think reclaiming is what happens when you write out dirty buffers to
disk etc.
johannes
next prev parent reply other threads:[~2018-01-24 10:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 7:40 [PATCH v2] mac80211_hwsim: don't use WQ_MEM_RECLAIM Johannes Berg
2018-01-24 9:39 ` Benjamin Beichler
2018-01-24 10:46 ` Johannes Berg [this message]
[not found] ` <CAF7Mx6oASGjDrzVq4_t8Wt-DU7Zap1tcpz5vU7bk-Q5qzg4V=g@mail.gmail.com>
[not found] ` <CAF7Mx6o_Y0AeGQfhGKMkSxUHtRNyGaHh3g-TyvusJmsYyckFZg@mail.gmail.com>
[not found] ` <CAF7Mx6rg2XOOG0mZxnKiM_1ToB36Yc2A=sKQfN7drLsr3+4crw@mail.gmail.com>
2018-01-25 20:20 ` Arend van Spriel
2018-01-25 21:01 ` Johannes Berg
2018-01-25 22:26 ` Tejun Heo
2018-01-26 8:08 ` Johannes Berg
2018-01-26 15:05 ` Tejun Heo
2018-01-26 15:53 ` Benjamin Beichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516790786.2508.43.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Benjamin.Beichler@uni-rostock.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).