From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jouni@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org,
Srinivas Dasari <dasaris@qti.qualcomm.com>
Subject: Re: [PATCH v3 2/3] cfg80211/nl80211: Optional authentication offload to userspace
Date: Tue, 30 Jan 2018 08:53:17 +0100 [thread overview]
Message-ID: <1517298797.2189.36.camel@sipsolutions.net> (raw)
In-Reply-To: <1516893219-30243-2-git-send-email-jouni@qca.qualcomm.com>
On Thu, 2018-01-25 at 17:13 +0200, Jouni Malinen wrote:
>
> + if (nla_get_flag(info->attrs[NL80211_ATTR_EXTERNAL_AUTH_SUPPORT]))
> + connect.flags |= CONNECT_REQ_EXTERNAL_AUTH_SUPPORT;
It seems like here we should check for connection owner, no?
If you say yes, I can edit that in.
> +int cfg80211_external_auth_request(struct net_device *dev,
> + struct cfg80211_external_auth_params *params,
> + gfp_t gfp)
> +{
> + struct wireless_dev *wdev = dev->ieee80211_ptr;
> + struct cfg80211_registered_device *rdev = wiphy_to_rdev(wdev->wiphy);
> + struct sk_buff *msg;
> + void *hdr;
> +
> + if (!wdev->conn_owner_nlportid)
> + return -EINVAL;
This still kinda makes sense, of course, though it should only happen
through races (connection owner goes away and we can't tear down the
connection quickly enough before this happens)
johannes
next prev parent reply other threads:[~2018-01-30 7:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 15:13 [PATCH v3 1/3] nl80211: Introduce scan flags to emphasize requested scan behavior Jouni Malinen
2018-01-25 15:13 ` [PATCH v3 2/3] cfg80211/nl80211: Optional authentication offload to userspace Jouni Malinen
2018-01-30 7:53 ` Johannes Berg [this message]
2018-01-31 10:57 ` Srinivas Dasari
2018-01-25 15:13 ` [PATCH v3 3/3] nl80211: Allow SAE Authentication for NL80211_CMD_CONNECT Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517298797.2189.36.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dasaris@qti.qualcomm.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).