From: Johannes Berg <johannes@sipsolutions.net>
To: Benjamin Beichler <Benjamin.Beichler@uni-rostock.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v4 2/3] mac80211_hwsim: add nl_err_msg in hwsim_new_radio in netlink case
Date: Wed, 31 Jan 2018 13:05:17 +0100 [thread overview]
Message-ID: <1517400317.2189.54.camel@sipsolutions.net> (raw)
In-Reply-To: <cf608fec-78d5-40f4-8601-50537d6f4e73@uni-rostock.de>
On Tue, 2018-01-30 at 10:47 +0100, Benjamin Beichler wrote:
> It should not be triggered because of already existing macs, I added it
> for somehow completeness, but you can leave it out.
Sure.
> After having again a look on it, there could be an -ENOMEM on
> rhashtable_insert. Maybe it's better to explicitly catch only -EEXIST
> and print for the rest an generic error. Do you agree ?
Nah, that's unlikely enough ... and you get -ENOMEM back in userspace
too.
That said, good thing I looked at this - you forgot a set of braces :-)
johannes
next prev parent reply other threads:[~2018-01-31 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 17:04 [PATCH v4 0/3] improvements for wmediumd-like simulations and config enhancements Benjamin Beichler
2018-01-22 17:04 ` [PATCH v4 1/3] mac80211_hwsim: add permanent mac address option for new radios Benjamin Beichler
2018-03-19 11:09 ` Jouni Malinen
2018-01-22 17:04 ` [PATCH v4 2/3] mac80211_hwsim: add nl_err_msg in hwsim_new_radio in netlink case Benjamin Beichler
2018-01-30 7:56 ` Johannes Berg
2018-01-30 9:47 ` Benjamin Beichler
2018-01-31 12:05 ` Johannes Berg [this message]
2018-01-31 14:49 ` Benjamin Beichler
2018-01-22 17:04 ` [PATCH v4 3/3] mac80211_hwsim: add generation count for netlink dump operation Benjamin Beichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517400317.2189.54.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Benjamin.Beichler@uni-rostock.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).