From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 5/6] nl80211: Implement TX of control port frames
Date: Wed, 31 Jan 2018 22:52:02 +0100 [thread overview]
Message-ID: <1517435522.2189.66.camel@sipsolutions.net> (raw)
In-Reply-To: <20180131213329.25322-6-denkenz@gmail.com> (sfid-20180131_223349_476233_D75A8C24)
On Wed, 2018-01-31 at 15:33 -0600, Denis Kenzior wrote:
>
> + return rdev_tx_control_port(rdev, dev, buf, len,
> + dest, cpu_to_be16(proto), noencrypt);
You're passing __be16 here
> +++ b/net/wireless/rdev-ops.h
> @@ -714,6 +714,21 @@ static inline int rdev_mgmt_tx(struct cfg80211_registered_device *rdev,
> return ret;
> }
>
> +static inline int rdev_tx_control_port(struct cfg80211_registered_device *rdev,
> + struct net_device *dev,
> + const void *buf, size_t len,
> + const u8 *dest, u16 proto,
> + const bool noencrypt)
but have u16 here - doesn't that make sparse unhappy?
Should also declare the API as __be16.
johannes
next prev parent reply other threads:[~2018-01-31 21:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 21:33 [RFC v3 0/6] EAPoL over NL80211 Denis Kenzior
2018-01-31 21:33 ` [PATCH 1/6] uapi: Add 802.11 Preauthentication to if_ether Denis Kenzior
2018-01-31 21:33 ` [PATCH 2/6] nl80211: Add CONTROL_PORT_OVER_NL80211 attribute Denis Kenzior
2018-01-31 21:33 ` [PATCH 3/6] nl80211: Add CMD_CONTROL_PORT_FRAME API Denis Kenzior
2018-01-31 21:45 ` Johannes Berg
2018-01-31 22:01 ` Denis Kenzior
2018-01-31 22:03 ` Johannes Berg
2018-01-31 21:33 ` [PATCH 4/6] mac80211: Send control port frames over nl80211 Denis Kenzior
2018-01-31 21:50 ` Johannes Berg
2018-01-31 21:33 ` [PATCH 5/6] nl80211: Implement TX of control port frames Denis Kenzior
2018-01-31 21:52 ` Johannes Berg [this message]
2018-01-31 21:53 ` Johannes Berg
2018-01-31 21:58 ` Denis Kenzior
2018-01-31 22:00 ` Johannes Berg
2018-01-31 21:33 ` [PATCH 6/6] mac80211: Add support for tx_control_port Denis Kenzior
2018-01-31 22:00 ` [RFC v3 0/6] EAPoL over NL80211 Johannes Berg
2018-02-01 1:09 ` Denis Kenzior
2018-02-01 8:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517435522.2189.66.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=denkenz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).