From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 5/6] nl80211: Implement TX of control port frames
Date: Wed, 31 Jan 2018 22:53:41 +0100 [thread overview]
Message-ID: <1517435621.2189.67.camel@sipsolutions.net> (raw)
In-Reply-To: <20180131213329.25322-6-denkenz@gmail.com> (sfid-20180131_223349_476233_D75A8C24)
> +static int nl80211_tx_control_port(struct sk_buff *skb, struct genl_info *info)
> +{
> + struct cfg80211_registered_device *rdev = info->user_ptr[0];
> + struct net_device *dev = info->user_ptr[1];
> + struct wireless_dev *wdev = dev->ieee80211_ptr;
> + const u8 *buf;
> + size_t len;
> + u8 *dest;
> + u16 proto;
> + bool noencrypt;
> + int err;
> +
> + if (!wiphy_ext_feature_isset(&rdev->wiphy,
> + NL80211_EXT_FEATURE_CONTROL_PORT_OVER_NL80211))
> + return -EOPNOTSUPP;
> +
> + if (!rdev->ops->tx_control_port)
> + return -EOPNOTSUPP;
I wonder if maybe we should accept this command only from the socket
owner? Is there a use case for something else?
Actually, then again, that's awkward because doing events and commands
on the same socket doesn't mix all _that_ well. Perhaps we just need to
fix that problem in libnl or something and be done with it ...
johannes
next prev parent reply other threads:[~2018-01-31 21:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 21:33 [RFC v3 0/6] EAPoL over NL80211 Denis Kenzior
2018-01-31 21:33 ` [PATCH 1/6] uapi: Add 802.11 Preauthentication to if_ether Denis Kenzior
2018-01-31 21:33 ` [PATCH 2/6] nl80211: Add CONTROL_PORT_OVER_NL80211 attribute Denis Kenzior
2018-01-31 21:33 ` [PATCH 3/6] nl80211: Add CMD_CONTROL_PORT_FRAME API Denis Kenzior
2018-01-31 21:45 ` Johannes Berg
2018-01-31 22:01 ` Denis Kenzior
2018-01-31 22:03 ` Johannes Berg
2018-01-31 21:33 ` [PATCH 4/6] mac80211: Send control port frames over nl80211 Denis Kenzior
2018-01-31 21:50 ` Johannes Berg
2018-01-31 21:33 ` [PATCH 5/6] nl80211: Implement TX of control port frames Denis Kenzior
2018-01-31 21:52 ` Johannes Berg
2018-01-31 21:53 ` Johannes Berg [this message]
2018-01-31 21:58 ` Denis Kenzior
2018-01-31 22:00 ` Johannes Berg
2018-01-31 21:33 ` [PATCH 6/6] mac80211: Add support for tx_control_port Denis Kenzior
2018-01-31 22:00 ` [RFC v3 0/6] EAPoL over NL80211 Johannes Berg
2018-02-01 1:09 ` Denis Kenzior
2018-02-01 8:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517435621.2189.67.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=denkenz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).