[PATCH] mac80211: inform wireless layer when frame RSSI is invalid

[PATCH] mac80211: inform wireless layer when frame RSSI is invalid

[Jean Pierre TOSONI]

V2hlbiB0aGUgbG93LWxldmVsIGRyaXZlciByZXR1cm5zIGFuIGludmFsaWQgUlNTSSBpbmRpY2F0
aW9uLA0Kc2V0IHRoZSBzaWduYWwgdmFsdWUgdG8gMCBhcyBhbiBpbmRpY2F0aW9uIHRvIHRoZSB1
cHBlciBsYXllci4NCg0KQWxzbywgc2tpcCBhdmVyYWdlIGxldmVsIGNvbXB1dGF0aW9uIGlmIHNp
Z25hbCBpcyBpbnZhbGlkLg0KDQpTaWduZWQtb2ZmLWJ5OiBKZWFuIFBpZXJyZSBUT1NPTkkgPGpw
LnRvc29uaUBhY2tzeXMuZnI+DQotLS0NCldBUk5JTkc6DQpUaGlzIHBhdGNoIGFwcGxpZXMgdG8g
d2lyZWxlc3MtdGVzdGluZyByZXRyaWV2ZWQgb24gRmViIDE0LCAyMDE4IGJ1dCBpdCB3YXMgdGVz
dGVkIG9uDQphIG11Y2ggb2xkZXIgdmVyc2lvbiAoT3BlbldydCBrZXJuZWwgMy4xOCB3aXRoIGNv
bXBhdC13aXJlbGVzcy0yMDE1LTA3LTIxKS4NCg0KIG5ldC9tYWM4MDIxMS9tbG1lLmMgfCAgICAz
ICsrKw0KIG5ldC9tYWM4MDIxMS9yeC5jICAgfCAgICA2ICsrKystLQ0KIG5ldC9tYWM4MDIxMS9z
Y2FuLmMgfCAgICA0ICsrKy0NCiAzIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDMg
ZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9uZXQvbWFjODAyMTEvbWxtZS5jIGIvbmV0L21h
YzgwMjExL21sbWUuYw0KaW5kZXggMzliNjYwYi4uOTlmZjY3OSAxMDA2NDQNCi0tLSBhL25ldC9t
YWM4MDIxMS9tbG1lLmMNCisrKyBiL25ldC9tYWM4MDIxMS9tbG1lLmMNCkBAIC0zMzY4LDYgKzMz
NjgsOCBAQCBzdGF0aWMgdm9pZCBpZWVlODAyMTFfcnhfbWdtdF9iZWFjb24oc3RydWN0IGllZWU4
MDIxMV9zdWJfaWZfZGF0YSAqc2RhdGEsDQogCWJzc2lkID0gaWZtZ2QtPmFzc29jaWF0ZWQtPmJz
c2lkOw0KIA0KIAkvKiBUcmFjayBhdmVyYWdlIFJTU0kgZnJvbSB0aGUgQmVhY29uIGZyYW1lcyBv
ZiB0aGUgY3VycmVudCBBUCAqLw0KKwlpZiAocnhfc3RhdHVzLT5mbGFnICYgUlhfRkxBR19OT19T
SUdOQUxfVkFMKQ0KKwkJZ290byBza2lwX3NpZ25hbF9wcm9jZXNzaW5nOw0KIAlpZiAoaWZtZ2Qt
PmZsYWdzICYgSUVFRTgwMjExX1NUQV9SRVNFVF9TSUdOQUxfQVZFKSB7DQogCQlpZm1nZC0+Zmxh
Z3MgJj0gfklFRUU4MDIxMV9TVEFfUkVTRVRfU0lHTkFMX0FWRTsNCiAJCWV3bWFfYmVhY29uX3Np
Z25hbF9pbml0KCZpZm1nZC0+YXZlX2JlYWNvbl9zaWduYWwpOw0KQEAgLTM0NTQsNiArMzQ1Niw3
IEBAIHN0YXRpYyB2b2lkIGllZWU4MDIxMV9yeF9tZ210X2JlYWNvbihzdHJ1Y3QgaWVlZTgwMjEx
X3N1Yl9pZl9kYXRhICpzZGF0YSwNCiAJCQkJc2lnLCBHRlBfS0VSTkVMKTsNCiAJCX0NCiAJfQ0K
K3NraXBfc2lnbmFsX3Byb2Nlc3Npbmc6DQogDQogCWlmIChpZm1nZC0+ZmxhZ3MgJiBJRUVFODAy
MTFfU1RBX0NPTk5FQ1RJT05fUE9MTCkgew0KIAkJbWxtZV9kYmdfcmF0ZWxpbWl0ZWQoc2RhdGEs
DQpkaWZmIC0tZ2l0IGEvbmV0L21hYzgwMjExL3J4LmMgYi9uZXQvbWFjODAyMTEvcnguYw0KaW5k
ZXggZTc1NWY5My4uOGQ2M2ExYiAxMDA2NDQNCi0tLSBhL25ldC9tYWM4MDIxMS9yeC5jDQorKysg
Yi9uZXQvbWFjODAyMTEvcnguYw0KQEAgLTI3OTEsNyArMjc5MSw4IEBAIHN0YXRpYyB2b2lkIGll
ZWU4MDIxMV9wcm9jZXNzX3NhX3F1ZXJ5X3JlcShzdHJ1Y3QgaWVlZTgwMjExX3N1Yl9pZl9kYXRh
ICpzZGF0YSwNCiAJICAgICEocngtPmZsYWdzICYgSUVFRTgwMjExX1JYX0JFQUNPTl9SRVBPUlRF
RCkpIHsNCiAJCWludCBzaWcgPSAwOw0KIA0KLQkJaWYgKGllZWU4MDIxMV9od19jaGVjaygmcngt
PmxvY2FsLT5odywgU0lHTkFMX0RCTSkpDQorCQlpZiAoaWVlZTgwMjExX2h3X2NoZWNrKCZyeC0+
bG9jYWwtPmh3LCBTSUdOQUxfREJNKSAmJg0KKwkJICAgICEoc3RhdHVzLT5mbGFnICYgUlhfRkxB
R19OT19TSUdOQUxfVkFMKSkNCiAJCQlzaWcgPSBzdGF0dXMtPnNpZ25hbDsNCiANCiAJCWNmZzgw
MjExX3JlcG9ydF9vYnNzX2JlYWNvbihyeC0+bG9jYWwtPmh3LndpcGh5LA0KQEAgLTMxMzIsNyAr
MzEzMyw4IEBAIHN0YXRpYyB2b2lkIGllZWU4MDIxMV9wcm9jZXNzX3NhX3F1ZXJ5X3JlcShzdHJ1
Y3QgaWVlZTgwMjExX3N1Yl9pZl9kYXRhICpzZGF0YSwNCiAJICogaXQgdHJhbnNtaXR0ZWQgd2Vy
ZSBwcm9jZXNzZWQgb3IgcmV0dXJuZWQuDQogCSAqLw0KIA0KLQlpZiAoaWVlZTgwMjExX2h3X2No
ZWNrKCZyeC0+bG9jYWwtPmh3LCBTSUdOQUxfREJNKSkNCisJaWYgKGllZWU4MDIxMV9od19jaGVj
aygmcngtPmxvY2FsLT5odywgU0lHTkFMX0RCTSkgJiYNCisJICAgICEoc3RhdHVzLT5mbGFnICYg
UlhfRkxBR19OT19TSUdOQUxfVkFMKSkNCiAJCXNpZyA9IHN0YXR1cy0+c2lnbmFsOw0KIA0KIAlp
ZiAoY2ZnODAyMTFfcnhfbWdtdCgmcngtPnNkYXRhLT53ZGV2LCBzdGF0dXMtPmZyZXEsIHNpZywN
CmRpZmYgLS1naXQgYS9uZXQvbWFjODAyMTEvc2Nhbi5jIGIvbmV0L21hYzgwMjExL3NjYW4uYw0K
aW5kZXggZWYyYmVjYS4uYTNiMWJjYyAxMDA2NDQNCi0tLSBhL25ldC9tYWM4MDIxMS9zY2FuLmMN
CisrKyBiL25ldC9tYWM4MDIxMS9zY2FuLmMNCkBAIC03Myw3ICs3Myw5IEBAIHN0cnVjdCBpZWVl
ODAyMTFfYnNzICoNCiAJYm9vbCBzaWduYWxfdmFsaWQ7DQogCXN0cnVjdCBpZWVlODAyMTFfc3Vi
X2lmX2RhdGEgKnNjYW5fc2RhdGE7DQogDQotCWlmIChpZWVlODAyMTFfaHdfY2hlY2soJmxvY2Fs
LT5odywgU0lHTkFMX0RCTSkpDQorCWlmIChyeF9zdGF0dXMtPmZsYWcgJiBSWF9GTEFHX05PX1NJ
R05BTF9WQUwpDQorCQlic3NfbWV0YS5zaWduYWwgPSAwOyAvKiBpbnZhbGlkIHNpZ25hbCBpbmRp
Y2F0aW9uICovDQorCWVsc2UgaWYgKGllZWU4MDIxMV9od19jaGVjaygmbG9jYWwtPmh3LCBTSUdO
QUxfREJNKSkNCiAJCWJzc19tZXRhLnNpZ25hbCA9IHJ4X3N0YXR1cy0+c2lnbmFsICogMTAwOw0K
IAllbHNlIGlmIChpZWVlODAyMTFfaHdfY2hlY2soJmxvY2FsLT5odywgU0lHTkFMX1VOU1BFQykp
DQogCQlic3NfbWV0YS5zaWduYWwgPSAocnhfc3RhdHVzLT5zaWduYWwgKiAxMDApIC8gbG9jYWwt
Pmh3Lm1heF9zaWduYWw7DQotLSANCjEuNy4yLjUNCg0K

Re: [PATCH] mac80211: inform wireless layer when frame RSSI is invalid

[Johannes Berg]

On Wed, 2018-02-14 at 13:51 +0000, Jean Pierre TOSONI wrote:
> When the low-level driver returns an invalid RSSI indication,
> set the signal value to 0 as an indication to the upper layer.
> 
> Also, skip average level computation if signal is invalid.

Thanks for the patch!

>  	/* Track average RSSI from the Beacon frames of the current AP */
> +	if (rx_status->flag & RX_FLAG_NO_SIGNAL_VAL)
> +		goto skip_signal_processing;
>  	if (ifmgd->flags & IEEE80211_STA_RESET_SIGNAL_AVE) {
>  		ifmgd->flags &= ~IEEE80211_STA_RESET_SIGNAL_AVE;
>  		ewma_beacon_signal_init(&ifmgd->ave_beacon_signal);
> @@ -3454,6 +3456,7 @@ static void ieee80211_rx_mgmt_beacon(struct ieee80211_sub_if_data *sdata,
>  				sig, GFP_KERNEL);
>  		}
>  	}
> +skip_signal_processing:

Can't say I like this - how about we pull out the actual processing
into a helper function, and then abort that function early if the
NO_SIGNAL_VAL flag is set.

johannes

RE: [PATCH] mac80211: inform wireless layer when frame RSSI is invalid

[Jean Pierre TOSONI]

DQo+IC0tLS0tTWVzc2FnZSBkJ29yaWdpbmUtLS0tLQ0KPiBEZcKgOiBKb2hhbm5lcyBCZXJnIFtt
YWlsdG86am9oYW5uZXNAc2lwc29sdXRpb25zLm5ldF0NCj4gRW52b3nDqcKgOiBsdW5kaSAxOSBm
w6l2cmllciAyMDE4IDEzOjM1DQo+IMOAwqA6IEplYW4gUGllcnJlIFRPU09OSTsgbGludXgtd2ly
ZWxlc3NAdmdlci5rZXJuZWwub3JnDQo+IE9iamV0wqA6IFJlOiBbUEFUQ0hdIG1hYzgwMjExOiBp
bmZvcm0gd2lyZWxlc3MgbGF5ZXIgd2hlbiBmcmFtZSBSU1NJDQo+IGlzIGludmFsaWQNCj4gDQoo
Li4uKQ0KPiANCj4gPiAgCS8qIFRyYWNrIGF2ZXJhZ2UgUlNTSSBmcm9tIHRoZSBCZWFjb24gZnJh
bWVzIG9mIHRoZSBjdXJyZW50IEFQDQo+ICovDQo+ID4gKwlpZiAocnhfc3RhdHVzLT5mbGFnICYg
UlhfRkxBR19OT19TSUdOQUxfVkFMKQ0KPiA+ICsJCWdvdG8gc2tpcF9zaWduYWxfcHJvY2Vzc2lu
ZzsNCj4gPiAgCWlmIChpZm1nZC0+ZmxhZ3MgJiBJRUVFODAyMTFfU1RBX1JFU0VUX1NJR05BTF9B
VkUpIHsNCj4gPiAgCQlpZm1nZC0+ZmxhZ3MgJj0gfklFRUU4MDIxMV9TVEFfUkVTRVRfU0lHTkFM
X0FWRTsNCj4gPiAgCQlld21hX2JlYWNvbl9zaWduYWxfaW5pdCgmaWZtZ2QtPmF2ZV9iZWFjb25f
c2lnbmFsKTsNCj4gPiBAQCAtMzQ1NCw2ICszNDU2LDcgQEAgc3RhdGljIHZvaWQgaWVlZTgwMjEx
X3J4X21nbXRfYmVhY29uKHN0cnVjdA0KPiBpZWVlODAyMTFfc3ViX2lmX2RhdGEgKnNkYXRhLA0K
PiA+ICAJCQkJc2lnLCBHRlBfS0VSTkVMKTsNCj4gPiAgCQl9DQo+ID4gIAl9DQo+ID4gK3NraXBf
c2lnbmFsX3Byb2Nlc3Npbmc6DQo+IA0KPiBDYW4ndCBzYXkgSSBsaWtlIHRoaXMgLSBob3cgYWJv
dXQgd2UgcHVsbCBvdXQgdGhlIGFjdHVhbCBwcm9jZXNzaW5nDQo+IGludG8gYSBoZWxwZXIgZnVu
Y3Rpb24sIGFuZCB0aGVuIGFib3J0IHRoYXQgZnVuY3Rpb24gZWFybHkgaWYgdGhlDQo+IE5PX1NJ
R05BTF9WQUwgZmxhZyBpcyBzZXQuDQo+IA0KDQpTaW5jZSBJIGFtIHdvcmtpbmcgb24gYW4gb2xk
ZXIgdmVyc2lvbiBvZiBtYWM4MDIxMSwgSSB3YXMgYWltaW5nIHRvDQprZWVwIGNoYW5nZXMgbWlu
aW1hbCB0byBhdm9pZCBicmVha2luZyBzb21ldGhpbmcgSSBjb3VsZCBub3QgdGVzdC4uLg0KSSds
bCBoYXZlIGEgbG9vayB0byB5b3VyIHN1Z2dlc3Rpb24uDQoNCj4gam9oYW5uZXMNCg==